Skip to content

Commit a787b0f

Browse files
authored
fix (pgvector): fix error messages to say pgvector instead of pinecone (#3654)
1 parent 3c69d10 commit a787b0f

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

integrations/pgvector/src/haystack_integrations/document_stores/pgvector/filters.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,14 +227,14 @@ def _less_than_equal(field: Composable, value: Any) -> tuple[Composed, Any]:
227227

228228
def _not_in(field: Composable, value: Any) -> tuple[Composed, list]:
229229
if not isinstance(value, list):
230-
msg = f"{field}'s value must be a list when using 'not in' comparator in Pinecone"
230+
msg = f"{field}'s value must be a list when using 'not in' comparator in PgVector"
231231
raise FilterError(msg)
232232
return SQL("({} IS NULL OR {} != ALL(%s))").format(field, field), [value]
233233

234234

235235
def _in(field: Composable, value: Any) -> tuple[Composed, list]:
236236
if not isinstance(value, list):
237-
msg = f"{field}'s value must be a list when using 'in' comparator in Pinecone"
237+
msg = f"{field}'s value must be a list when using 'in' comparator in PgVector"
238238
raise FilterError(msg)
239239

240240
# see https://www.psycopg.org/psycopg3/docs/basic/adapt.html#lists-adaptation

integrations/pgvector/tests/test_filters.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,14 @@ def test_comparison_condition_unknown_operator():
183183
_parse_comparison_condition(condition)
184184

185185

186+
@pytest.mark.parametrize("operator", ["like", "not like"])
187+
def test_comparison_condition_like_operator_requires_str_value(operator):
188+
# pgvector-specific: LIKE / NOT LIKE require a string operand.
189+
condition = {"field": "meta.name", "operator": operator, "value": 123}
190+
with pytest.raises(FilterError, match="must be a str when using 'LIKE'"):
191+
_parse_comparison_condition(condition)
192+
193+
186194
def test_logical_condition_missing_operator():
187195
condition = {"conditions": []}
188196
with pytest.raises(FilterError):

0 commit comments

Comments
 (0)