Skip to content

Commit a7d6570

Browse files
committed
refactor: remove unused legacy parameters from __init__
- Addresses review feedback from @davidsbatista - Removed: sql_url, faiss_index_factory_str, similarity, isolation_level, duplicate_documents, return_embedding, progress_bar - Updated docstrings
1 parent f8eed17 commit a7d6570

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

integrations/faiss/src/haystack_integrations/document_stores/faiss/document_store.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,9 @@ class FAISSDocumentStore:
2525

2626
def __init__(
2727
self,
28-
sql_url: str = "sqlite:///:memory:", # Kept for compatibility but unused
2928
index_path: str | None = None,
3029
index_string: str = "Flat",
3130
embedding_dim: int = 768,
32-
faiss_index_factory_str: str | None = None, # Legacy parameter support
33-
similarity: str = "dot_product", # Legacy parameter
34-
isolation_level: str | None = None, # Legacy parameter
35-
duplicate_documents: str = "overwrite", # Legacy parameter
36-
return_embedding: bool = True,
37-
progress_bar: bool = True, # Legacy parameter
3831
):
3932
"""
4033
Initializes the FAISSDocumentStore.

0 commit comments

Comments
 (0)