test: Pinecone - improve flaky tests (#2787)

* test: Pinecone - try to fix flaky tests

* improvs

Author: anakin87

integrations/pinecone/pyproject.toml

@@ -71,7 +71,7 @@ all = 'pytest {args:tests}'
 
 # Pinecone tests are slow (require HTTP requests), so we run them in parallel
 # with pytest-xdist (https://pytest-xdist.readthedocs.io/en/stable/distribution.html)
-cov-retry = 'pytest -n auto --maxprocesses=2 --cov=haystack_integrations --reruns 3 --reruns-delay 30 -x {args:tests}'
+cov-retry = 'pytest -n auto --cov=haystack_integrations --reruns 3 --reruns-delay 30 -x {args:tests}'
 
 types = """mypy -p haystack_integrations.components.retrievers.pinecone \
 -p haystack_integrations.document_stores.pinecone {args}"""

integrations/pinecone/tests/conftest.py

@@ -10,12 +10,13 @@
 from haystack_integrations.document_stores.pinecone import PineconeDocumentStore
 
 # This is the approximate time in seconds it takes for the documents to be available
-SLEEP_TIME_IN_SECONDS = 25
+WRITE_SLEEP_TIME_IN_SECONDS = 25
+DELETE_SLEEP_TIME_IN_SECONDS = 30
 
 
 @pytest.fixture()
-def sleep_time():
-    return SLEEP_TIME_IN_SECONDS
+def delete_sleep_time():
+    return DELETE_SLEEP_TIME_IN_SECONDS
 
 
 @pytest.fixture
@@ -40,14 +41,14 @@ def document_store(request):
 
     def write_documents_and_wait(documents, policy=DuplicatePolicy.NONE):
         written_docs = original_write_documents(documents, policy)
-        time.sleep(SLEEP_TIME_IN_SECONDS)
+        time.sleep(WRITE_SLEEP_TIME_IN_SECONDS)
         return written_docs
 
     original_delete_documents = store.delete_documents
 
     def delete_documents_and_wait(filters):
         original_delete_documents(filters)
-        time.sleep(SLEEP_TIME_IN_SECONDS)
+        time.sleep(DELETE_SLEEP_TIME_IN_SECONDS)
 
     store.write_documents = write_documents_and_wait
     store.delete_documents = delete_documents_and_wait
@@ -81,14 +82,14 @@ async def document_store_async(request):
 
     async def write_documents_and_wait_async(documents, policy=DuplicatePolicy.NONE):
         written_docs = await original_write_documents(documents, policy)
-        await asyncio.sleep(SLEEP_TIME_IN_SECONDS)
+        await asyncio.sleep(WRITE_SLEEP_TIME_IN_SECONDS)
         return written_docs
 
     original_delete_documents = store.delete_documents_async
 
     async def delete_documents_and_wait_async(filters):
         await original_delete_documents(filters)
-        await asyncio.sleep(SLEEP_TIME_IN_SECONDS)
+        await asyncio.sleep(DELETE_SLEEP_TIME_IN_SECONDS)
 
     store.write_documents_async = write_documents_and_wait_async
     store.delete_documents_async = delete_documents_and_wait_async

integrations/pinecone/tests/test_document_store.py

@@ -217,7 +217,7 @@ def test_convert_meta_to_int():
 
 @pytest.mark.integration
 @pytest.mark.skipif(not os.environ.get("PINECONE_API_KEY"), reason="PINECONE_API_KEY not set")
-def test_serverless_index_creation_from_scratch(sleep_time):
+def test_serverless_index_creation_from_scratch(delete_sleep_time):
     # we use a fixed index name to avoid hitting the limit of Pinecone's free tier (max 5 indexes)
     # the index name is defined in the test matrix of the GitHub Actions workflow
     # the default value is provided for local testing
@@ -229,7 +229,7 @@ def test_serverless_index_creation_from_scratch(sleep_time):
     except Exception:  # noqa S110
         pass
 
-    time.sleep(sleep_time)
+    time.sleep(delete_sleep_time)
 
     ds = PineconeDocumentStore(
         index=index_name,