cleaning up

Author: davidsbatista

integrations/pgvector/tests/test_document_store.py

@@ -467,7 +467,6 @@ def test_update_by_filter_advanced_filters(document_store: PgvectorDocumentStore
     )
     assert updated_count == 2
 
-    # Verify both documents were updated
     featured_docs = document_store.filter_documents(filters={"field": "meta.featured", "operator": "==", "value": True})
     assert len(featured_docs) == 2
 
@@ -477,6 +476,5 @@ def test_update_by_filter_empty_meta_raises_error(document_store: PgvectorDocume
     docs = [Document(content="Doc 1", meta={"category": "A"})]
     document_store.write_documents(docs)
 
-    # Empty meta dict should raise ValueError
     with pytest.raises(ValueError, match="meta must be a non-empty dictionary"):
         document_store.update_by_filter(filters={"field": "meta.category", "operator": "==", "value": "A"}, meta={})

integrations/pgvector/tests/test_document_store_async.py

@@ -117,19 +117,16 @@ async def test_delete_by_filter_async(self, document_store: PgvectorDocumentStor
         await document_store.write_documents_async(docs)
         assert await document_store.count_documents_async() == 3
 
-        # Delete documents with category="A"
         deleted_count = await document_store.delete_by_filter_async(
             filters={"field": "meta.category", "operator": "==", "value": "A"}
         )
         assert deleted_count == 2
         assert await document_store.count_documents_async() == 1
 
-        # Verify only category B remains
         remaining_docs = await document_store.filter_documents_async()
         assert len(remaining_docs) == 1
         assert remaining_docs[0].meta["category"] == "B"
 
-        # Delete remaining document with year filter
         deleted_count = await document_store.delete_by_filter_async(
             filters={"field": "meta.year", "operator": "==", "value": 2023}
         )
@@ -144,14 +141,13 @@ async def test_delete_by_filter_async_no_matches(self, document_store: PgvectorD
         await document_store.write_documents_async(docs)
         assert await document_store.count_documents_async() == 2
 
-        # Try to delete documents with category="C" (no matches)
         deleted_count = await document_store.delete_by_filter_async(
             filters={"field": "meta.category", "operator": "==", "value": "C"}
         )
         assert deleted_count == 0
         assert await document_store.count_documents_async() == 2
 
-    async def test_delete_by_filter_async_complex_filters(self, document_store: PgvectorDocumentStore):
+    async def test_delete_by_filter_async_advanced_filters(self, document_store: PgvectorDocumentStore):
         docs = [
             Document(content="Doc 1", meta={"category": "A", "year": 2023, "status": "draft"}),
             Document(content="Doc 2", meta={"category": "A", "year": 2024, "status": "published"}),
@@ -160,7 +156,7 @@ async def test_delete_by_filter_async_complex_filters(self, document_store: Pgve
         await document_store.write_documents_async(docs)
         assert await document_store.count_documents_async() == 3
 
-        # Delete with AND condition
+        # AND condition
         deleted_count = await document_store.delete_by_filter_async(
             filters={
                 "operator": "AND",
@@ -173,7 +169,7 @@ async def test_delete_by_filter_async_complex_filters(self, document_store: Pgve
         assert deleted_count == 1
         assert await document_store.count_documents_async() == 2
 
-        # Delete with OR condition
+        # OR condition
         deleted_count = await document_store.delete_by_filter_async(
             filters={
                 "operator": "OR",
@@ -226,14 +222,14 @@ async def test_update_by_filter_async_multiple_fields(self, document_store: Pgve
         await document_store.write_documents_async(docs)
         assert await document_store.count_documents_async() == 3
 
-        # Update multiple fields for category="A" documents
+        # update multiple fields for category="A" documents
         updated_count = await document_store.update_by_filter_async(
             filters={"field": "meta.category", "operator": "==", "value": "A"},
             meta={"status": "published", "priority": "high", "reviewed": True},
         )
         assert updated_count == 2
 
-        # Verify the updates
+        # verify
         published_docs = await document_store.filter_documents_async(
             filters={"field": "meta.category", "operator": "==", "value": "A"}
         )
@@ -244,7 +240,7 @@ async def test_update_by_filter_async_multiple_fields(self, document_store: Pgve
             assert doc.meta["reviewed"] is True
             assert doc.meta["year"] == 2023  # Original field should still be present
 
-        # Verify category B was not updated
+        # verify category B was not updated
         b_docs = await document_store.filter_documents_async(
             filters={"field": "meta.category", "operator": "==", "value": "B"}
         )
@@ -260,20 +256,20 @@ async def test_update_by_filter_async_no_matches(self, document_store: PgvectorD
         await document_store.write_documents_async(docs)
         assert await document_store.count_documents_async() == 2
 
-        # Try to update documents with category="C" (no matches)
+        # update documents with category="C" (no matches)
         updated_count = await document_store.update_by_filter_async(
             filters={"field": "meta.category", "operator": "==", "value": "C"}, meta={"status": "published"}
         )
         assert updated_count == 0
         assert await document_store.count_documents_async() == 2
 
-        # Verify no documents were updated
+        # verify no documents were updated
         published_docs = await document_store.filter_documents_async(
             filters={"field": "meta.status", "operator": "==", "value": "published"}
         )
         assert len(published_docs) == 0
 
-    async def test_update_by_filter_async_complex_filters(self, document_store: PgvectorDocumentStore):
+    async def test_update_by_filter_async_advanced_filters(self, document_store: PgvectorDocumentStore):
         docs = [
             Document(content="Doc 1", meta={"category": "A", "year": 2023, "status": "draft"}),
             Document(content="Doc 2", meta={"category": "A", "year": 2024, "status": "draft"}),
@@ -282,7 +278,7 @@ async def test_update_by_filter_async_complex_filters(self, document_store: Pgve
         await document_store.write_documents_async(docs)
         assert await document_store.count_documents_async() == 3
 
-        # Update with AND condition
+        # AND condition
         updated_count = await document_store.update_by_filter_async(
             filters={
                 "operator": "AND",
@@ -295,15 +291,15 @@ async def test_update_by_filter_async_complex_filters(self, document_store: Pgve
         )
         assert updated_count == 1
 
-        # Verify only one document was updated
+        # verify
         published_docs = await document_store.filter_documents_async(
             filters={"field": "meta.status", "operator": "==", "value": "published"}
         )
         assert len(published_docs) == 1
         assert published_docs[0].meta["category"] == "A"
         assert published_docs[0].meta["year"] == 2023
 
-        # Update with OR condition
+        # OR condition
         updated_count = await document_store.update_by_filter_async(
             filters={
                 "operator": "OR",
@@ -316,7 +312,6 @@ async def test_update_by_filter_async_complex_filters(self, document_store: Pgve
         )
         assert updated_count == 2
 
-        # Verify both documents were updated
         featured_docs = await document_store.filter_documents_async(
             filters={"field": "meta.featured", "operator": "==", "value": True}
         )
@@ -326,7 +321,6 @@ async def test_update_by_filter_async_empty_meta_raises_error(self, document_sto
         docs = [Document(content="Doc 1", meta={"category": "A"})]
         await document_store.write_documents_async(docs)
 
-        # Empty meta dict should raise ValueError
         with pytest.raises(ValueError, match="meta must be a non-empty dictionary"):
             await document_store.update_by_filter_async(
                 filters={"field": "meta.category", "operator": "==", "value": "A"}, meta={}