Commit d1915ee
committed
fix: AmazonBedrockDocumentEmbedder to not modify Documents in place (#2174)
- Add dataclasses.replace import
- Update _embed_cohere to create new document instances
- Update _embed_titan to create new document instances
- Add immutability tests for both Cohere and Titan paths
- Update CHANGELOG.md with bug fix entry
Follows the pattern from FastEmbed, Optimum, and Nvidia integrations.1 parent 1017c72 commit d1915ee
4 files changed
Lines changed: 83 additions & 41 deletions
File tree
- integrations/amazon_bedrock
- src/haystack_integrations/components
- embedders/amazon_bedrock
- rankers/amazon_bedrock
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
30 | | - | |
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
| |||
57 | 55 | | |
58 | 56 | | |
59 | 57 | | |
60 | | - | |
61 | 58 | | |
62 | 59 | | |
63 | 60 | | |
| |||
67 | 64 | | |
68 | 65 | | |
69 | 66 | | |
70 | | - | |
71 | 67 | | |
72 | 68 | | |
73 | 69 | | |
| |||
84 | 80 | | |
85 | 81 | | |
86 | 82 | | |
87 | | - | |
88 | 83 | | |
89 | 84 | | |
90 | 85 | | |
| |||
100 | 95 | | |
101 | 96 | | |
102 | 97 | | |
103 | | - | |
104 | 98 | | |
105 | 99 | | |
106 | 100 | | |
| |||
117 | 111 | | |
118 | 112 | | |
119 | 113 | | |
120 | | - | |
121 | 114 | | |
122 | 115 | | |
123 | 116 | | |
124 | 117 | | |
125 | 118 | | |
126 | 119 | | |
127 | | - | |
128 | 120 | | |
129 | 121 | | |
130 | 122 | | |
| |||
136 | 128 | | |
137 | 129 | | |
138 | 130 | | |
139 | | - | |
140 | 131 | | |
141 | 132 | | |
142 | 133 | | |
| |||
154 | 145 | | |
155 | 146 | | |
156 | 147 | | |
157 | | - | |
158 | 148 | | |
159 | 149 | | |
160 | 150 | | |
161 | 151 | | |
162 | 152 | | |
163 | 153 | | |
164 | | - | |
165 | 154 | | |
166 | 155 | | |
167 | 156 | | |
168 | 157 | | |
169 | 158 | | |
170 | 159 | | |
171 | | - | |
172 | 160 | | |
173 | 161 | | |
174 | 162 | | |
| |||
183 | 171 | | |
184 | 172 | | |
185 | 173 | | |
186 | | - | |
187 | 174 | | |
188 | 175 | | |
189 | 176 | | |
| |||
205 | 192 | | |
206 | 193 | | |
207 | 194 | | |
208 | | - | |
209 | 195 | | |
210 | 196 | | |
211 | 197 | | |
| |||
224 | 210 | | |
225 | 211 | | |
226 | 212 | | |
227 | | - | |
228 | 213 | | |
229 | 214 | | |
230 | 215 | | |
| |||
235 | 220 | | |
236 | 221 | | |
237 | 222 | | |
238 | | - | |
239 | 223 | | |
240 | 224 | | |
241 | 225 | | |
| |||
246 | 230 | | |
247 | 231 | | |
248 | 232 | | |
249 | | - | |
250 | 233 | | |
251 | 234 | | |
252 | 235 | | |
253 | 236 | | |
254 | 237 | | |
255 | 238 | | |
256 | | - | |
257 | 239 | | |
258 | 240 | | |
259 | 241 | | |
| |||
275 | 257 | | |
276 | 258 | | |
277 | 259 | | |
278 | | - | |
279 | 260 | | |
280 | 261 | | |
281 | 262 | | |
282 | 263 | | |
283 | | - | |
| 264 | + | |
284 | 265 | | |
285 | 266 | | |
286 | 267 | | |
287 | 268 | | |
288 | | - | |
289 | | - | |
| 269 | + | |
290 | 270 | | |
291 | 271 | | |
292 | 272 | | |
293 | 273 | | |
294 | 274 | | |
295 | 275 | | |
296 | 276 | | |
297 | | - | |
298 | 277 | | |
299 | 278 | | |
300 | 279 | | |
| |||
307 | 286 | | |
308 | 287 | | |
309 | 288 | | |
310 | | - | |
311 | 289 | | |
312 | 290 | | |
313 | 291 | | |
314 | 292 | | |
315 | 293 | | |
316 | 294 | | |
317 | | - | |
318 | 295 | | |
319 | 296 | | |
320 | 297 | | |
321 | 298 | | |
322 | 299 | | |
323 | 300 | | |
324 | | - | |
325 | 301 | | |
326 | 302 | | |
327 | 303 | | |
328 | 304 | | |
329 | 305 | | |
330 | | - | |
| 306 | + | |
331 | 307 | | |
332 | 308 | | |
333 | 309 | | |
| |||
347 | 323 | | |
348 | 324 | | |
349 | 325 | | |
350 | | - | |
351 | 326 | | |
352 | 327 | | |
353 | 328 | | |
354 | 329 | | |
355 | 330 | | |
356 | 331 | | |
357 | | - | |
358 | 332 | | |
359 | 333 | | |
360 | 334 | | |
361 | 335 | | |
362 | 336 | | |
363 | 337 | | |
364 | | - | |
365 | 338 | | |
366 | 339 | | |
367 | 340 | | |
368 | 341 | | |
369 | | - | |
| 342 | + | |
370 | 343 | | |
371 | 344 | | |
372 | 345 | | |
| |||
379 | 352 | | |
380 | 353 | | |
381 | 354 | | |
382 | | - | |
| 355 | + | |
383 | 356 | | |
384 | 357 | | |
385 | 358 | | |
| |||
391 | 364 | | |
392 | 365 | | |
393 | 366 | | |
394 | | - | |
395 | 367 | | |
396 | 368 | | |
397 | 369 | | |
| |||
402 | 374 | | |
403 | 375 | | |
404 | 376 | | |
405 | | - | |
406 | 377 | | |
407 | 378 | | |
408 | 379 | | |
| |||
466 | 437 | | |
467 | 438 | | |
468 | 439 | | |
469 | | - | |
| 440 | + | |
470 | 441 | | |
471 | 442 | | |
472 | 443 | | |
| |||
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
| 190 | + | |
189 | 191 | | |
190 | | - | |
| 192 | + | |
191 | 193 | | |
192 | | - | |
| 194 | + | |
193 | 195 | | |
194 | 196 | | |
195 | 197 | | |
| |||
214 | 216 | | |
215 | 217 | | |
216 | 218 | | |
| 219 | + | |
217 | 220 | | |
218 | | - | |
| 221 | + | |
219 | 222 | | |
220 | | - | |
| 223 | + | |
221 | 224 | | |
222 | 225 | | |
223 | 226 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
251 | 252 | | |
252 | 253 | | |
253 | 254 | | |
254 | | - | |
255 | | - | |
| 255 | + | |
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
| |||
Lines changed: 68 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
260 | 328 | | |
261 | 329 | | |
262 | 330 | | |
| |||
0 commit comments