Skip to content

Commit d41c334

Browse files
committed
add comments and clearer error messages
1 parent 4b4b96c commit d41c334

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

  • integrations/chroma/src/haystack_integrations/document_stores/chroma

integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,13 @@ def _ensure_initialized(self):
111111
)
112112
raise ValueError(error_message)
113113

114+
# Use dict to conditionally pass settings because Chroma doesn't accept settings=None
114115
client_kwargs: dict[str, Any] = {}
115116
if self._client_settings:
116117
try:
117118
client_kwargs["settings"] = Settings(**self._client_settings)
118119
except ValueError as e:
119-
msg = f"Invalid client_settings: {e}"
120+
msg = f"Invalid client_settings ({self._client_settings}): {e}"
120121
raise ValueError(msg) from e
121122

122123
if self._host and self._port is not None:
@@ -166,12 +167,13 @@ async def _ensure_initialized_async(self):
166167
)
167168
raise ValueError(error_message)
168169

170+
# Use dict to conditionally pass settings because Chroma doesn't accept settings=None
169171
client_kwargs: dict[str, Any] = {}
170172
if self._client_settings:
171173
try:
172174
client_kwargs["settings"] = Settings(**self._client_settings)
173175
except ValueError as e:
174-
msg = f"Invalid client_settings: {e}"
176+
msg = f"Invalid client_settings ({self._client_settings}): {e}"
175177
raise ValueError(msg) from e
176178

177179
client = await chromadb.AsyncHttpClient(

0 commit comments

Comments
 (0)