using Mixin tests and fixing get_metadata_field_min_max 'meta' prefix removal

Author: davidsbatista

integrations/arcadedb/src/haystack_integrations/document_stores/arcadedb/document_store.py

@@ -526,7 +526,8 @@ def get_metadata_field_min_max(self, metadata_field: str) -> dict[str, Any]:
         """
         self._ensure_initialized()
 
-        field_ref = f"meta[{_sql_str(metadata_field)}]"
+        field_name = metadata_field.removeprefix("meta.")
+        field_ref = f"meta[{_sql_str(field_name)}]"
         sql = f"SELECT MIN({field_ref}) AS min_value, MAX({field_ref}) AS max_value FROM `{self._type_name}`"
         rows = self._command(sql)
 

integrations/arcadedb/tests/test_document_store.py

@@ -9,7 +9,15 @@
 from haystack import Document
 from haystack.document_stores.errors import DuplicateDocumentError
 from haystack.document_stores.types import DuplicatePolicy
-from haystack.testing.document_store import DocumentStoreBaseExtendedTests
+from haystack.testing.document_store import (
+    CountDocumentsByFilterTest,
+    CountUniqueMetadataByFilterTest,
+    DocumentStoreBaseExtendedTests,
+    FilterableDocsFixtureMixin,
+    GetMetadataFieldMinMaxTest,
+    GetMetadataFieldsInfoTest,
+    GetMetadataFieldUniqueValuesTest,
+)
 
 from haystack_integrations.document_stores.arcadedb import ArcadeDBDocumentStore
 
@@ -48,7 +56,15 @@ def test_to_dict_from_dict(self):
     reason="Set ARCADEDB_PASSWORD (e.g. via repo secret in CI) to run integration tests.",
 )
 @pytest.mark.integration
-class TestArcadeDBDocumentStore(DocumentStoreBaseExtendedTests):
+class TestArcadeDBDocumentStore(
+    CountDocumentsByFilterTest,
+    CountUniqueMetadataByFilterTest,
+    DocumentStoreBaseExtendedTests,
+    FilterableDocsFixtureMixin,
+    GetMetadataFieldMinMaxTest,
+    GetMetadataFieldsInfoTest,
+    GetMetadataFieldUniqueValuesTest
+):
     """
     Run Haystack DocumentStore mixin tests against ArcadeDBDocumentStore.
 
@@ -124,32 +140,6 @@ def test_embedding_retrieval(self, document_store: ArcadeDBDocumentStore):
         assert len(results) <= 3
         assert results[0].score is not None
 
-    def test_count_documents_by_filter(self, document_store: ArcadeDBDocumentStore):
-        """Counts only documents matching the provided filter."""
-        docs = [
-            Document(id="1", content="Doc 1", meta={"category": "news", "status": "published", "priority": 3}),
-            Document(id="2", content="Doc 2", meta={"category": "docs", "status": "draft", "priority": 1}),
-            Document(id="3", content="Doc 3", meta={"category": "news", "status": "published", "priority": 5}),
-        ]
-        document_store.write_documents(docs)
-
-        count = document_store.count_documents_by_filter(
-            {"field": "meta.status", "operator": "==", "value": "published"}
-        )
-
-        assert count == 2
-
-    def test_count_documents_by_filter_no_matches(self, document_store: ArcadeDBDocumentStore):
-        """Returns zero when no documents match the filter."""
-        docs = [
-            Document(id="1", content="Doc 1", meta={"category": "news"}),
-        ]
-        document_store.write_documents(docs)
-
-        count = document_store.count_documents_by_filter({"field": "meta.status", "operator": "==", "value": "sports"})
-
-        assert count == 0
-
     def test_count_documents_by_empty_filter(self, document_store: ArcadeDBDocumentStore):
         """Counts all documents when an empty filter is provided."""
         docs = [
@@ -161,23 +151,6 @@ def test_count_documents_by_empty_filter(self, document_store: ArcadeDBDocumentS
 
         assert count == 1
 
-    def test_count_unique_metadata_by_filter(self, document_store: ArcadeDBDocumentStore):
-        """Counts unique values per field across documents matching the filter."""
-        docs = [
-            Document(id="1", content="Doc 1", meta={"category": "news", "status": "published", "priority": 1}),
-            Document(id="2", content="Doc 2", meta={"category": "docs", "status": "published", "priority": 2}),
-            Document(id="3", content="Doc 3", meta={"category": "news", "status": "published", "priority": 2}),
-            Document(id="4", content="Doc 4", meta={"category": "faq", "status": "draft", "priority": 3}),
-        ]
-        document_store.write_documents(docs)
-
-        counts = document_store.count_unique_metadata_by_filter(
-            {"field": "meta.status", "operator": "==", "value": "published"},
-            ["category", "priority"],
-        )
-
-        assert counts == {"category": 2, "priority": 2}
-
     def test_count_unique_metadata_by_filter_empty_fields(self, document_store: ArcadeDBDocumentStore):
         """Returns an empty dict when no metadata fields are requested."""
         docs = [
@@ -192,57 +165,6 @@ def test_count_unique_metadata_by_filter_empty_fields(self, document_store: Arca
 
         assert counts == {}
 
-    def test_count_unique_metadata_by_empty_filter(self, document_store: ArcadeDBDocumentStore):
-        """Counts unique values across all documents when filter is empty."""
-        docs = [
-            Document(id="1", content="Doc 1", meta={"category": "news"}),
-        ]
-        document_store.write_documents(docs)
-
-        counts = document_store.count_unique_metadata_by_filter({}, ["category"])
-
-        assert counts == {"category": 1}
-
-    def test_get_metadata_fields_info(self, document_store: ArcadeDBDocumentStore):
-        """Returns correct Haystack type strings for all metadata field types."""
-        docs = [
-            Document(
-                id="1", content="Doc 1", meta={"category": "news", "status": "published", "priority": 1, "active": True}
-            ),
-            Document(
-                id="2", content="Doc 2", meta={"category": "docs", "status": "draft", "priority": 2.5, "active": False}
-            ),
-        ]
-        document_store.write_documents(docs)
-
-        fields_info = document_store.get_metadata_fields_info()
-
-        assert fields_info == {
-            "content": {"type": "text"},
-            "category": {"type": "keyword"},
-            "status": {"type": "keyword"},
-            "priority": {"type": "long"},
-            "active": {"type": "boolean"},
-        }
-
-    def test_get_metadata_fields_info_empty_store(self, document_store: ArcadeDBDocumentStore):
-        """Returns an empty dict when the store contains no documents."""
-        result = document_store.get_metadata_fields_info()
-        assert result == {}
-
-    def test_get_metadata_field_min_max(self, document_store: ArcadeDBDocumentStore):
-        """Returns the correct min and max for a numeric metadata field."""
-        docs = [
-            Document(id="1", content="Doc 1", meta={"priority": 3}),
-            Document(id="2", content="Doc 2", meta={"priority": 1}),
-            Document(id="3", content="Doc 3", meta={"priority": 7}),
-        ]
-        document_store.write_documents(docs)
-
-        result = document_store.get_metadata_field_min_max("priority")
-
-        assert result == {"min": 1, "max": 7}
-
     def test_get_metadata_field_min_max_nonexistent_field(self, document_store: ArcadeDBDocumentStore):
         """Returns None for both min and max when the field does not exist."""
         docs = [Document(id="1", content="Doc 1", meta={"category": "news"})]
@@ -252,23 +174,6 @@ def test_get_metadata_field_min_max_nonexistent_field(self, document_store: Arca
 
         assert result == {"min": None, "max": None}
 
-    def test_get_metadata_field_unique_values(self, document_store: ArcadeDBDocumentStore):
-        """Returns values matching the search term and the correct total count."""
-        docs = [
-            Document(id="1", content="Doc 1", meta={"category": "alpha"}),
-            Document(id="2", content="Doc 2", meta={"category": "beta"}),
-            Document(id="3", content="Doc 3", meta={"category": "alphabet"}),
-            Document(id="4", content="Doc 4", meta={"category": "gamma"}),
-        ]
-        document_store.write_documents(docs)
-
-        values, total_count = document_store.get_metadata_field_unique_values(
-            "category", search_term="alp", from_=0, size=10
-        )
-
-        assert sorted(values) == ["alpha", "alphabet"]
-        assert total_count == 2
-
     def test_get_metadata_field_unique_values_pagination(self, document_store: ArcadeDBDocumentStore):
         """Respects size limit while total reflects the full unpaginated count."""
         docs = [