Skip to content

Commit f1535f0

Browse files
committed
improving/organising tests and using Mixin
1 parent 93c72f9 commit f1535f0

2 files changed

Lines changed: 13 additions & 8 deletions

File tree

integrations/oracle/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ classifiers = [
2222
"Programming Language :: Python :: Implementation :: CPython",
2323
]
2424
dependencies = [
25-
"haystack-ai>=2.27.0",
25+
"haystack-ai>=2.28.0",
2626
"oracledb>=2.1.0,<3.0.0",
2727
]
2828

integrations/oracle/tests/test_document_store.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@
1010
from haystack.document_stores.errors import DuplicateDocumentError
1111
from haystack.document_stores.types import DuplicatePolicy
1212
from haystack.testing.document_store import (
13-
CountDocumentsByFilterAsyncTest,
1413
CountDocumentsByFilterTest,
15-
CountUniqueMetadataByFilterAsyncTest,
1614
CountUniqueMetadataByFilterTest,
1715
DeleteAllTest,
1816
DeleteByFilterTest,
@@ -21,9 +19,14 @@
2119
GetMetadataFieldMinMaxTest,
2220
GetMetadataFieldsInfoTest,
2321
GetMetadataFieldUniqueValuesTest,
24-
UpdateByFilterAsyncTest,
2522
UpdateByFilterTest,
2623
)
24+
from haystack.testing.document_store_async import (
25+
CountDocumentsByFilterAsyncTest,
26+
CountUniqueMetadataByFilterAsyncTest,
27+
FilterableDocsFixtureMixin,
28+
UpdateByFilterAsyncTest,
29+
)
2730
from haystack.utils import Secret
2831

2932
from haystack_integrations.document_stores.oracle import OracleConnectionConfig, OracleDocumentStore
@@ -48,17 +51,14 @@ def _uid(suffix: str = "") -> str:
4851
class TestOracleDocumentStore(
4952
DocumentStoreBaseTests,
5053
CountDocumentsByFilterTest,
51-
CountDocumentsByFilterAsyncTest,
5254
CountUniqueMetadataByFilterTest,
53-
CountUniqueMetadataByFilterAsyncTest,
5455
DeleteAllTest,
5556
DeleteByFilterTest,
5657
DeleteDocumentsTest,
5758
GetMetadataFieldMinMaxTest,
5859
GetMetadataFieldsInfoTest,
5960
GetMetadataFieldUniqueValuesTest,
6061
UpdateByFilterTest,
61-
UpdateByFilterAsyncTest,
6262
):
6363
@staticmethod
6464
def _mock_doc(content="hello", embedding=None, doc_id="AABB" * 8):
@@ -313,7 +313,12 @@ def test_create_table_idempotent(self, document_store):
313313

314314

315315
@pytest.mark.integration
316-
class TestOracleDocumentStoreAsync:
316+
class TestOracleDocumentStoreAsync(
317+
FilterableDocsFixtureMixin,
318+
CountDocumentsByFilterAsyncTest,
319+
CountUniqueMetadataByFilterAsyncTest,
320+
UpdateByFilterAsyncTest,
321+
):
317322
"""Async API surface tests."""
318323

319324
@pytest.mark.asyncio

0 commit comments

Comments
 (0)