bug: Unclosed aiohttp Sessions When Using `PineconeDocumentStore` with `run_async`

[Amnah199]

Describe the bug
When using PineconeDocumentStore with run_async , unclosed aiohttp client session and connector errors occur during embedding_retrieval . This seems to stem from not using the IndexAsyncio client within an async context manager, as recommended by Pinecone.

To Reproduce
The issue is explained by a community member on discord: https://discord.com/channels/993534733298450452/993539071815200889/1359252922608652319

Suggested Fix
Using IndexAsyncio inside an async with context (as shown in the user workaround) resolves the issue.

[anakin87]

Code

logging.basicConfig(stream=sys.stdout, level=logging.INFO)
embedder = AmazonBedrockTextEmbedder(model="amazon.titan-embed-text-v2:0")
retriever = PineconeEmbeddingRetriever(
    document_store=PineconeDocumentStore()
)
async def embed_and_retrieve(query):
    query_embedding = embedder.run(query)
    documents = await retriever.run_async(query_embedding=query_embedding["embedding"], top_k=5)
    return documents

tasks = [embed_and_retrieve(query) for query in queries]
task_results = await asyncio.gather(*tasks)
task_results

Output

ERROR:asyncio:Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0xffff5c9e1a50>
ERROR:asyncio:Unclosed connector
connections: ['deque([(<aiohttp.client_proto.ResponseHandler object at 0xffff5c9dec10>, 12586.186699688)])']
connector: <aiohttp.connector.TCPConnector object at 0xffff5d737550>
ERROR:asyncio:Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0xffff5c294590>
ERROR:asyncio:Unclosed connector
connections: ['deque([(<aiohttp.client_proto.ResponseHandler object at 0xffff5c9de890>, 12586.193114521)])']
connector: <aiohttp.connector.TCPConnector object at 0xffff5c28ac50>
ERROR:asyncio:Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0xffff5c9cca50>
ERROR:asyncio:Unclosed connector
connections: ['deque([(<aiohttp.client_proto.ResponseHandler object at 0xffff5c9de6d0>, 12586.197866563)])']
connector: <aiohttp.connector.TCPConnector object at 0xffff5c98cdd0>
INFO:haystack_integrations.document_stores.pinecone.document_store:Connecting to existing index .. `dimension`, `spec`, and `metric` will be ignored.
ERROR:asyncio:Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0xffff5c29e110>
ERROR:asyncio:Unclosed connector
connections: ['deque([(<aiohttp.client_proto.ResponseHandler object at 0xffff5c9de740>, 12586.589836188), (<aiohttp.client_proto.ResponseHandler object at 0xffff5c90ad60>, 12586.865545605), (<aiohttp.client_proto.ResponseHandler object at 0xffff5c90b230>, 12586.878553647), (<aiohttp.client_proto.ResponseHandler object at 0xffff5c90b770>, 12586.889237605)])']
connector: <aiohttp.connector.TCPConnector object at 0xffff5c29dfd0>