feat!: Deprecate SSEServerInfo base_url in favour of url#1662
Conversation
|
@anakin87 @mpangrazzi is already familiar with this discussion - it is a small change that will improve devX as users are mostly used to providing MCP server URL with |
|
cc @bilgeyucel this is the devX upgrade we talked about |
|
@anakin87 @mpangrazzi can you please take another look now? There are some minor internal simplifications that are not public and make everything much simpler |
|
I am ignoring this PR because I thought that Michele had more context. In case it is urgent, please let me know. |
|
@anakin87 np, @mpangrazzi has all the context and @oryx1729 can also chime in with his UI/UX experience around this matter |
mpangrazzi
left a comment
There was a problem hiding this comment.
LGTM! - I've left only a minor comment
Why
This PR deprecates the
base_urlparameter in favor of a singleurlargument for configuring the SSE client. It adds deprecation warnings and updates relevant classes to reflect this change.This change aligns with common usage patterns—users are typically more familiar with providing the full URL including the
/sseendpoint, and omitting it (viabase_url) can be unintuitive or error-prone. Simplifying the interface improves clarity and consistency.Details
base_urlis used.urlorbase_urlcan be passed.SSEClientandSSEServerInfoto enforce and reflect this change.Deprecation Notice
base_urlis now deprecated and will be removed in a future release. Please switch to using the fullurl(including the/ssepath) when initializing the client.Checklist