Skip to content

build!: align naming convention of hatch script#1880

Closed
srini047 wants to merge 1 commit intodeepset-ai:mainfrom
srini047:align_hatch_naming_convention
Closed

build!: align naming convention of hatch script#1880
srini047 wants to merge 1 commit intodeepset-ai:mainfrom
srini047:align_hatch_naming_convention

Conversation

@srini047
Copy link
Copy Markdown
Contributor

@srini047 srini047 commented May 30, 2025

Related Issues

Proposed Changes:

Old New
lint:fmt lint:format

How did you test it?

Using:

  • hatch run lint:format

Notes for the reviewer

Please add more details to the issue description as needed.

Checklist

@srini047 srini047 requested a review from a team as a code owner May 30, 2025 21:15
@srini047 srini047 requested review from sjrl and removed request for a team May 30, 2025 21:15
@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Jun 2, 2025

Hey @srini047 thanks for your quick work on this! However, we'd first like to discuss this change as a team before committing to it. So I'll get back to you once we have done so.

@anakin87
Copy link
Copy Markdown
Member

anakin87 commented Jun 6, 2025

Hey @srini047, thanks for this PR...

I took over this task because it was somewhat sensitive. For example, it interacts closely with #1771.

Thank you again for your dedication!

@anakin87 anakin87 closed this Jun 6, 2025
@anakin87 anakin87 mentioned this pull request Jun 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment