Skip to content

fix: Fix types in the Google Gen AI embedders#1916

Merged
sjrl merged 6 commits into
mainfrom
google-genai-embedders
Jun 12, 2025
Merged

fix: Fix types in the Google Gen AI embedders#1916
sjrl merged 6 commits into
mainfrom
google-genai-embedders

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented Jun 10, 2025

Related Issues

  • fixes #issue-number

Proposed Changes:

  • Fix types in the Google Gen AI embedders
  • Update tests

How did you test it?

  • hatch run test:types

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner June 10, 2025 09:31
@sjrl sjrl requested review from mpangrazzi and removed request for a team June 10, 2025 09:31
@sjrl sjrl self-assigned this Jun 10, 2025
@github-actions github-actions Bot added the type:documentation Improvements or additions to documentation label Jun 10, 2025
Copy link
Copy Markdown
Contributor

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjrl sjrl merged commit adde318 into main Jun 12, 2025
10 checks passed
@sjrl sjrl deleted the google-genai-embedders branch June 12, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:google-genai type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants