Skip to content

fix: prompts and schemas of GitHubIssueCommenterTool and GitHubIssueViewerTool now properly explain url parameter#1929

Merged
julian-risch merged 4 commits intomainfrom
github-integration-prompt-fix
Jun 12, 2025
Merged

fix: prompts and schemas of GitHubIssueCommenterTool and GitHubIssueViewerTool now properly explain url parameter#1929
julian-risch merged 4 commits intomainfrom
github-integration-prompt-fix

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Jun 11, 2025

Related Issues

  • None. @bilgeyucel and I discovered this bug when an Agent failed to properly call the Tool and instead returned the message:
ChatMessage(_role=<ChatRole.TOOL: 'tool'>, _content=[ToolCallResult(result='Failed to invoke Tool `github_issue_commenter` with parameters {\'comment\': "Thank you for bringing this issue to our attention! We appreciate your detailed bug report and want to assure you that we\'re currently investigating the problem. We\'ll keep you updated on our progress. If you have any more information to share, please feel free to comment!"}. Error: GitHubIssueCommenter.run() missing 1 required positional argument: \'url\'', origin=ToolCall(tool_name='github_issue_commenter', arguments={'comment': "Thank you for bringing this issue to our attention! We appreciate your detailed bug report and want to assure you that we're currently investigating the problem. We'll keep you updated on our progress. If you have any more information to share, please feel free to comment!"}, id='call_JLVltg9JWtlbfmHTrvO9lyXs'), error=True)]

Proposed Changes:

  • Use url instead of issue_url in ISSUE_VIEWER_PROMPT and ISSUE_VIEWER_SCHEMA
  • Explain url param in ISSUE_COMMENTER_SCHEMA and ISSUE_COMMENTER_PROMPT

How did you test it?

locally as part of testing the usage examples that I drafted for documentation pages

Notes for the reviewer

Checklist

@julian-risch julian-risch requested a review from a team as a code owner June 11, 2025 19:55
@julian-risch julian-risch requested review from sjrl and removed request for a team June 11, 2025 19:55
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@julian-risch julian-risch merged commit a5e8aea into main Jun 12, 2025
10 checks passed
@julian-risch julian-risch deleted the github-integration-prompt-fix branch June 12, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants