fix: GitHubRepoForker should check if branch is accessible before continuing#1939
Closed
julian-risch wants to merge 1 commit intomainfrom
Closed
fix: GitHubRepoForker should check if branch is accessible before continuing#1939julian-risch wants to merge 1 commit intomainfrom
julian-risch wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
I ran into 404 errors when using the GitHub Forker. The fork was always created correctly but the error was raised. When the fork is created it still takes a few seconds before the branch becomes accessible.
_check_fork_statusonly checked for the repo to exist until now. This PR extends the check to also ensure the branch is accessible.Proposed Changes:
_check_fork_statusand check that only the forked repo is accessible but also its branches.How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.