chore: type improvements related to select_streaming_callback overloads#2008
Merged
chore: type improvements related to select_streaming_callback overloads#2008
select_streaming_callback overloads#2008Conversation
select_streaming_callback overloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
select_streaming_callbacktype hints haystack#9513, I tried to improve type hints forselect_streaming_callback, adding overloads variantsboolparameter with 2 variants (Literal[True]andLiteral[False]) is exhaustive. See (🐞)overloads that exhaust finiteLiterals(bool/Enum) not treated as exhaustive python/mypy#14764.Proposed Changes:
type: ignorethanks to the overloads introducedHow did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.