Skip to content

chore: type improvements related to select_streaming_callback overloads#2008

Merged
anakin87 merged 1 commit intomainfrom
streaming-callback-types
Jun 27, 2025
Merged

chore: type improvements related to select_streaming_callback overloads#2008
anakin87 merged 1 commit intomainfrom
streaming-callback-types

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Jun 27, 2025

Related Issues

Proposed Changes:

  • Bedrock: ignore this type error
  • Cohere and Anthropic: remove type: ignore thanks to the overloads introduced

How did you test it?

CI

Checklist

@anakin87 anakin87 changed the title chore: improve typing for select_streaming_callback chore: type improvements related to select_streaming_callback overloads Jun 27, 2025
@anakin87 anakin87 marked this pull request as ready for review June 27, 2025 08:09
@anakin87 anakin87 requested a review from a team as a code owner June 27, 2025 08:09
@anakin87 anakin87 requested review from davidsbatista and removed request for a team June 27, 2025 08:09
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anakin87 anakin87 merged commit 1c27cd0 into main Jun 27, 2025
22 checks passed
@anakin87 anakin87 deleted the streaming-callback-types branch June 27, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants