fix: Prevent MCPToolset GC during toolset add#2019
Merged
Conversation
Member
Author
|
Hey @Amnah199 do you have time to take a look at this one today? |
Contributor
|
@vblagoje taking a look now 👍 |
Amnah199
reviewed
Jul 1, 2025
Amnah199
reviewed
Jul 1, 2025
Contributor
Amnah199
left a comment
There was a problem hiding this comment.
LG already! Just a small comment.
Member
Author
|
@Amnah199 can you please take another look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Fixes a garbage collection issue that prevented users from properly combining multiple MCPToolset instances using the inline syntax
tools.add(MCPToolset(...)). When MCPToolset objects were created inline and added to another toolset, Python's garbage collector would prematurely destroy the temporary toolset objects, closing their MCP connections and leaving orphaned tools that failed with "Not connected to an MCP server" errors.What:
owner_toolsetparameter to maintain strong references to prevent garbage collectionHow can it be used:
How did you test it:
Notes for the reviewer:
N/A