Conversation
Contributor
Author
|
Failing deepeval tests are unrelated to these changes. They would be fixed by this PR #2476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
I recently noticed in some failing test logs that it looked like we weren't rerunning failing tests despite having
pytest-rerunfailuresset up. Additionally it appeared like the-xcommand was being ignored as well.Here is an example failing test log for meta-llama where we don't appear to rerun the failed test (missing the RERUN log from pytest) and we still continue to run tests after that one failed which goes against the
-xoption.It appears something goes wrong when using
hatch run test:cov-retrywith the configurationwhen I changed it to (same command as the one we use in haystack-experimental)
then I was able to see RERUN logs and early exits occur. Here is an example for meta-llama.
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.