Skip to content

Feature/valkey document store#2589

Merged
sjrl merged 17 commits into
deepset-ai:mainfrom
daric93:feature/valkey-document-store
Jan 29, 2026
Merged

Feature/valkey document store#2589
sjrl merged 17 commits into
deepset-ai:mainfrom
daric93:feature/valkey-document-store

Conversation

@daric93
Copy link
Copy Markdown
Contributor

@daric93 daric93 commented Dec 5, 2025

Related Issues

Valkey Document Store
#2574

Proposed Changes:

Implemented ValkeyDocumentStore as a built-in integration for Haystack. This component follows Haystack’s DocumentStore interface using Valkey’s search module for vector similarity and metadata-based filtering.

Valkey supports all essential capabilities required by the DocumentStore interface.
How did you test it?

  • unit tests
  • integration tests
  • manual test (running example with haystack integration)

Checklist

@daric93 daric93 requested a review from a team as a code owner December 5, 2025 19:54
@daric93 daric93 requested review from sjrl and removed request for a team December 5, 2025 19:54
@github-actions github-actions Bot added topic:CI type:documentation Improvements or additions to documentation labels Dec 5, 2025
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 5, 2025

CLA assistant check
All committers have signed the CLA.

@daric93 daric93 force-pushed the feature/valkey-document-store branch 3 times, most recently from d9c48f3 to 2a84745 Compare December 8, 2025 16:00
Comment thread integrations/valkey/LICENSE.txt Outdated
Comment thread integrations/valkey/README.md
@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Dec 19, 2025

@daric93 thanks for the contribution!

Some feedback:

  • Update the labeler.yml file to include integration:valkey
  • Remove the file integrations/__init__.py which is here. This is purposely omitted since this messes up how namespacing works for our core integration packages.

I'll continue with a more in-depth review, but we are quite busy so this might take some time.

Comment thread .github/workflows/valkey.yml Outdated
Comment thread integrations/valkey/pyproject.toml Outdated
Comment thread integrations/valkey/pyproject.toml Outdated
Comment thread integrations/valkey/pyproject.toml Outdated
Comment thread integrations/valkey/pyproject.toml Outdated
Comment thread integrations/valkey/src/haystack_integrations/document_stores/valkey/__init__.py Outdated
@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Dec 19, 2025

Also the test folder structure should be updated. We follow the pattern that there should be one test file per real file in the integration. So we should only have:

  • test_document_store.py
  • test_document_store_async.py
  • test_embedding_retriever.py
  • test_filters.py

So rename your existing files and merge the other ones (test_static_methods.py and test_dict_converters.py)

@daric93 daric93 requested review from anakin87 and sjrl January 22, 2026 19:45
@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Jan 23, 2026

Thanks for the second round of review! I have addressed all the comments. Please take another look when you have time.

Thanks! I should have time to give it another look early next week.

@sjrl
Copy link
Copy Markdown
Contributor

sjrl commented Jan 28, 2026

One last additional comment. Could you update this file https://github.com/deepset-ai/haystack-core-integrations/blob/main/README.md to include a row in the table for this new integratiom

@daric93 daric93 force-pushed the feature/valkey-document-store branch from d0cee4d to 21eecb9 Compare January 28, 2026 19:50
@daric93
Copy link
Copy Markdown
Contributor Author

daric93 commented Jan 28, 2026

One last additional comment. Could you update this file https://github.com/deepset-ai/haystack-core-integrations/blob/main/README.md to include a row in the table for this new integratiom

added row for valkey

@daric93
Copy link
Copy Markdown
Contributor Author

daric93 commented Jan 28, 2026

Thanks for the feedback! I've addressed new comments.
Please review again when you have a chance.

@daric93 daric93 requested a review from sjrl January 28, 2026 20:09
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@sjrl sjrl merged commit 422f47a into deepset-ai:main Jan 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:valkey new integration Discuss the creation of a new integration in Core topic:CI type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants