Feature/valkey document store#2589
Conversation
d9c48f3 to
2a84745
Compare
|
@daric93 thanks for the contribution! Some feedback:
I'll continue with a more in-depth review, but we are quite busy so this might take some time. |
|
Also the test folder structure should be updated. We follow the pattern that there should be one test file per real file in the integration. So we should only have:
So rename your existing files and merge the other ones ( |
Thanks! I should have time to give it another look early next week. |
|
One last additional comment. Could you update this file https://github.com/deepset-ai/haystack-core-integrations/blob/main/README.md to include a row in the table for this new integratiom |
Co-authored-by: Sebastian Husch Lee <10526848+sjrl@users.noreply.github.com>
d0cee4d to
21eecb9
Compare
added row for valkey |
|
Thanks for the feedback! I've addressed new comments. |
sjrl
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Related Issues
Valkey Document Store
#2574
Proposed Changes:
Implemented ValkeyDocumentStore as a built-in integration for Haystack. This component follows Haystack’s DocumentStore interface using Valkey’s search module for vector similarity and metadata-based filtering.
Valkey supports all essential capabilities required by the DocumentStore interface.
How did you test it?
Checklist