fix: Update google genai streaming test#2630
Merged
Merged
Conversation
github-actions
Bot
added
integration:google-genai
type:documentation
sjrl
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Fixes test failure caused by Haystack core PR 10248 which added reasoning content accumulation to streaming chunks.
What:
Added
reasoningattribute to mock StreamingChunk objects intest_aggregate_streaming_chunks_with_reasoning.How can it be used:
Test now properly mocks chunks with
reasoning=Noneorreasoning=ReasoningContent(reasoning_text="...")matching the new Haystack core API.How did you test it:
Verified
test_aggregate_streaming_chunks_with_reasoningpasses, no regressions.Notes for the reviewer:
Mock objects now simulate the
reasoningattribute expected by_convert_streaming_chunks_to_chat_message()after the above-mentioned Haystack PR.