fix: OpenSearch async client initialization#2645
Merged
Merged
Conversation
Contributor
|
Thanks for your proposal @Nitro963 This makes sense, but I would rather do it differently, since this might introduce lots of overhead each time an operation is performed. Ideally, creating a |
Contributor
Author
|
@davidsbatista I've updated implementation with a new initialization method |
Contributor
|
thanks @Nitro963 LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
In async environment
_ensure_initializedsync method is being called on the main thread, and as it may take time depending on network it will cause the entire event loop to block and the application will freeze until all retries finished if any.How did you test it?
Manual testing within FastAPI async server