Skip to content

feat: adding delete_by_filter and update_by_filter to PineconeDocumentStore#2655

Merged
davidsbatista merged 9 commits into
mainfrom
feat/add-update-delete-by-filter-to-PineConeDocumentStore
Jan 8, 2026
Merged

feat: adding delete_by_filter and update_by_filter to PineconeDocumentStore#2655
davidsbatista merged 9 commits into
mainfrom
feat/add-update-delete-by-filter-to-PineConeDocumentStore

Conversation

@davidsbatista
Copy link
Copy Markdown
Contributor

@davidsbatista davidsbatista commented Jan 6, 2026

Related Issues

Proposed Changes:

  • delete_by_filter() - Delete documents matching filter criteria
  • update_by_filter() - Update metadata of documents matching filter criteria

How did you test it?

  • integration tests similar to the ones already existing for other document stores

Checklist

@github-actions github-actions Bot added integration:pinecone type:documentation Improvements or additions to documentation labels Jan 6, 2026
@davidsbatista davidsbatista changed the title feat: adding delete_by_filter and updated_by_filter + tests feat: adding delete_by_filter and update_by_filter` to PineconeDocumentStore Jan 6, 2026
@davidsbatista davidsbatista marked this pull request as ready for review January 6, 2026 14:12
@davidsbatista davidsbatista requested a review from a team as a code owner January 6, 2026 14:12
@davidsbatista davidsbatista requested review from vblagoje and removed request for a team January 6, 2026 14:12
@davidsbatista davidsbatista changed the title feat: adding delete_by_filter and update_by_filter` to PineconeDocumentStore feat: adding delete_by_filter and update_by_filter to PineconeDocumentStore` Jan 6, 2026
@davidsbatista davidsbatista changed the title feat: adding delete_by_filter and update_by_filter to PineconeDocumentStore` feat: adding delete_by_filter and update_by_filter to PineconeDocumentStore Jan 6, 2026
Copy link
Copy Markdown
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this _log_top_k_limit_warning - seems unrelated?

index=self.index_name,
)

self._log_top_k_limit_warning(deleted_count, "deleted")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems out of place, no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove this, did as well for other doc stores already.

@davidsbatista davidsbatista merged commit 830e658 into main Jan 8, 2026
6 checks passed
@davidsbatista davidsbatista deleted the feat/add-update-delete-by-filter-to-PineConeDocumentStore branch January 8, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:pinecone type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add update_by_filter() and delete_by_filter() operations to PineConeDocumentStore

2 participants