chore: fix Pinecone types and make sure that tests run#2658
Merged
Conversation
anakin87
changed the title
sjrl
reviewed
Jan 7, 2026
| ) | ||
|
|
||
| documents_for_pinecone.append(doc_for_pinecone) | ||
| documents_for_pinecone.append((document.id, embedding, metadata)) |
Contributor
There was a problem hiding this comment.
Surprising that the dict version was working if pinecone was expecting tuples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
There was an error on Pinecone test matrix that prevented tests from running
haystack-core-integrations/.github/workflows/pinecone.yml
Lines 36 to 40 in 454d9ee
When I ran tests with Python 3.10, I realized they have released a new version with stricter types
Proposed Changes:
How did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.