Skip to content

feat: add count with filtering + fields operations to ElasticSearch document store#2666

Closed
davidsbatista wants to merge 117 commits into
mainfrom
feat/add-count-filtering-to-ElasticSearchDocumentStore
Closed

feat: add count with filtering + fields operations to ElasticSearch document store#2666
davidsbatista wants to merge 117 commits into
mainfrom
feat/add-count-filtering-to-ElasticSearchDocumentStore

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

Adding more operations to this DocumentStore, namely:

count_documents_by_filter()
count_distinct_values_by_filter()
get_fields_info()
get_field_min_max()
get_field_unique_values()
query_sql()

along with the async version of each

How did you test it?

  • added integration tests for each function both for sync and async versions

Notes for the reviewer

  • In a next PR we should separate the sync and async tests, since the file is already above 1k lines

Checklist

@github-actions github-actions Bot added integration:elasticsearch type:documentation Improvements or additions to documentation labels Jan 7, 2026
@davidsbatista davidsbatista changed the title Feat/add count filtering to elastic search document store feat: add count with filtering + fields operations to ElasticSearch document store Jan 7, 2026
@davidsbatista davidsbatista marked this pull request as ready for review January 8, 2026 09:42
@davidsbatista davidsbatista requested a review from a team as a code owner January 8, 2026 09:42
@davidsbatista davidsbatista requested review from vblagoje and removed request for a team January 8, 2026 09:42
@davidsbatista davidsbatista marked this pull request as draft January 8, 2026 09:42
@davidsbatista davidsbatista removed the request for review from vblagoje January 8, 2026 09:42
@davidsbatista davidsbatista marked this pull request as ready for review January 9, 2026 16:04
@davidsbatista davidsbatista requested review from sjrl and tstadel January 9, 2026 16:05
@davidsbatista

Copy link
Copy Markdown
Contributor Author

@tstadel adding you as well, but more for awareness and if you want to give a quick look
@sjrl since ElasticSearch API is very similar to OpenSearch I've added you but feel free to unassign yourself and add someone else

@davidsbatista davidsbatista deleted the feat/add-count-filtering-to-ElasticSearchDocumentStore branch January 16, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment