feat: Update Optimum components to auto call run warm_up and don't modify Documents in place#2675
Merged
Conversation
github-actions
Bot
added
the
type:documentation
sjrl
changed the title
OptimumDocumentEmbedder and OptimumTextEmbedder to auto call run warm_up on first run instead raising errorwarm_up and don't modify Documents in place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
RuntimeErrorif a Component has not been warmed up callwarm_upat runtime #2592Proposed Changes:
Update
OptimumDocumentEmbedderandOptimumTextEmbedderto auto call runwarm_upon first run instead raising errorHow did you test it?
Updated tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.