Skip to content

chore!: cometapi - drop Python 3.9 and use X|Y typing #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anakin87 merged 1 commit into from
Jan 9, 2026
Merged

chore!: cometapi - drop Python 3.9 and use X|Y typing #2697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions integrations/cometapi/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = "cometapi-haystack"
dynamic = ["version"]
description = 'Use Comet API with Haystack to build AI applications with 500+ AI models.'
readme = "README.md"
requires-python = ">=3.9"
requires-python = ">=3.10"
license = "Apache-2.0"
keywords = []
authors = [
Expand All @@ -18,15 +18,14 @@ classifiers = [
"License :: OSI Approved :: Apache Software License",
"Development Status :: 4 - Beta",
"Programming Language :: Python",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
]
dependencies = ["haystack-ai>=2.13.2",]
dependencies = ["haystack-ai>=2.22.0",]

[project.urls]
Documentation = "https://github.com/deepset-ai/haystack-core-integrations/tree/main/integrations/cometapi#readme"
Expand Down Expand Up @@ -85,7 +84,6 @@ module = [
ignore_missing_imports = true

[tool.ruff]
target-version = "py39"
line-length = 120

[tool.ruff.lint]
Expand Down Expand Up @@ -138,10 +136,6 @@ ignore = [
# Allow function call argument defaults e.g. `Secret.from_env_var`
"B008",
]
unfixable = [
# Don't touch unused imports
"F401",
]

[tool.ruff.lint.isort]
known-first-party = ["haystack_integrations"]
Expand Down
14 changes: 7 additions & 7 deletions .../cometapi/src/haystack_integrations/components/generators/cometapi/chat/chat_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Any, Optional, Union
from typing import Any

from haystack.components.generators.chat import OpenAIChatGenerator
from haystack.dataclasses import StreamingCallbackT
Expand Down Expand Up @@ -34,13 +34,13 @@ def __init__(
*,
api_key: Secret = Secret.from_env_var("COMET_API_KEY"),
model: str = "gpt-5-mini",
streaming_callback: Optional[StreamingCallbackT] = None,
generation_kwargs: Optional[dict[str, Any]] = None,
timeout: Optional[int] = None,
max_retries: Optional[int] = None,
tools: Optional[Union[list[Union[Tool, Toolset]], Toolset]] = None,
streaming_callback: StreamingCallbackT | None = None,
generation_kwargs: dict[str, Any] | None = None,
timeout: int | None = None,
max_retries: int | None = None,
tools: list[Tool | Toolset] | Toolset | None = None,
tools_strict: bool = False,
http_client_kwargs: Optional[dict[str, Any]] = None,
http_client_kwargs: dict[str, Any] | None = None,
):
api_base_url = "https://api.cometapi.com/v1"

Expand Down
Loading