Skip to content

fix: Fix github integration unit tests#2703

Merged
sjrl merged 1 commit intomainfrom
fix-github-tests
Jan 12, 2026
Merged

fix: Fix github integration unit tests#2703
sjrl merged 1 commit intomainfrom
fix-github-tests

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented Jan 12, 2026

Related Issues

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

@sjrl sjrl requested a review from a team as a code owner January 12, 2026 08:44
@sjrl sjrl requested review from julian-risch and vblagoje and removed request for a team January 12, 2026 08:44
@sjrl sjrl self-assigned this Jan 12, 2026
Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 My understanding is that added tool validation hooks surfaced these bugs and PR #2659 was an earlier attempt to fix them

@vblagoje
Copy link
Copy Markdown
Member

LGTM! 👍 My understanding is that added tool validation hooks surfaced these bugs and PR #2659 was an earlier attempt to fix them

Yes!

Copy link
Copy Markdown
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sjrl sjrl merged commit 32bad32 into main Jan 12, 2026
10 checks passed
@sjrl sjrl deleted the fix-github-tests branch January 12, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants