Conversation
vblagoje
approved these changes
Jan 12, 2026
vblagoje
left a comment
vblagoje
left a comment
Member
There was a problem hiding this comment.
Nice, learned about strict=True in zip
davidsbatista
pushed a commit
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
part of deepset-ai/haystack#10268
Proposed Changes
How did you test it?
CI
Notes for the reviewer
Since this is breaking, I'll release a new major version when merged.
This PR is partly generated using a script and reviewed/contributed to by me.