Skip to content

chore!: support X|Y typing and llama-stack>=0.4.0 #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anakin87 wants to merge 2 commits into from
Closed

chore!: support X|Y typing and llama-stack>=0.4.0 #2711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b44ad1a
chore!: support X|Y typing and llama-stack>=0.4.0
anakin87 Jan 12, 2026
5b81bf9
fix tests
anakin87 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/llama_stack/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ classifiers = [
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
]
dependencies = ["haystack-ai>=2.19.0", "llama-stack>=0.2.17"]
dependencies = ["haystack-ai>=2.22.0", "llama-stack>=0.4.0"]

[project.urls]
Documentation = "https://github.com/deepset-ai/haystack-core-integrations/tree/main/integrations/llama-stack#readme"
Expand Down
18 changes: 9 additions & 9 deletions ..._stack/src/haystack_integrations/components/generators/llama_stack/chat/chat_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#
# SPDX-License-Identifier: Apache-2.0

from typing import Any, Optional
from typing import Any

from haystack import component, default_from_dict, default_to_dict, logging
from haystack.components.generators.chat import OpenAIChatGenerator
Expand Down Expand Up @@ -59,15 +59,15 @@ def __init__(
self,
*,
model: str,
api_base_url: str = "http://localhost:8321/v1/openai/v1",
organization: Optional[str] = None,
streaming_callback: Optional[StreamingCallbackT] = None,
generation_kwargs: Optional[dict[str, Any]] = None,
timeout: Optional[int] = None,
tools: Optional[ToolsType] = None,
api_base_url: str = "http://localhost:8321/v1",
organization: str | None = None,
streaming_callback: StreamingCallbackT | None = None,
generation_kwargs: dict[str, Any] | None = None,
timeout: int | None = None,
tools: ToolsType | None = None,
tools_strict: bool = False,
max_retries: Optional[int] = None,
http_client_kwargs: Optional[dict[str, Any]] = None,
max_retries: int | None = None,
http_client_kwargs: dict[str, Any] | None = None,
):
"""
Creates an instance of LlamaStackChatGenerator. To use this chat generator,
Expand Down
4 changes: 2 additions & 2 deletions integrations/llama_stack/tests/test_llama_stack_chat_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class TestLlamaStackChatGenerator:
def test_init_default(self):
component = LlamaStackChatGenerator(model="ollama/llama3.2:3b")
assert component.model == "ollama/llama3.2:3b"
assert component.api_base_url == "http://localhost:8321/v1/openai/v1"
assert component.api_base_url == "http://localhost:8321/v1"
assert component.streaming_callback is None
assert not component.generation_kwargs

Expand Down Expand Up @@ -134,7 +134,7 @@ def test_to_dict_default(
expected_params = {
"model": "ollama/llama3.2:3b",
"streaming_callback": None,
"api_base_url": "http://localhost:8321/v1/openai/v1",
"api_base_url": "http://localhost:8321/v1",
"generation_kwargs": {},
"timeout": None,
"max_retries": None,
Expand Down
Loading