Skip to content

feat: QdrantDocumentStore return number deleted docs on delete_by_filter#2807

Merged
davidsbatista merged 1 commit into
mainfrom
fix/update-delete_by_filter-qdrant-signature
Feb 2, 2026
Merged

feat: QdrantDocumentStore return number deleted docs on delete_by_filter#2807
davidsbatista merged 1 commit into
mainfrom
fix/update-delete_by_filter-qdrant-signature

Conversation

@davidsbatista
Copy link
Copy Markdown
Contributor

@davidsbatista davidsbatista commented Feb 2, 2026

Related Issues

Proposed Changes:

How did you test it?

Checklist

@davidsbatista davidsbatista marked this pull request as ready for review February 2, 2026 16:14
@davidsbatista davidsbatista requested a review from a team as a code owner February 2, 2026 16:14
@davidsbatista davidsbatista requested review from julian-risch and removed request for a team February 2, 2026 16:14
Copy link
Copy Markdown
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Alternative approach would have been to use count_documents before and after the delete call but I don't think that's better.
Interestingly, there is an open issue in the qdrant repo about returning the number of deleted documents in the delete response: qdrant/qdrant#5761

@davidsbatista davidsbatista merged commit f706c17 into main Feb 2, 2026
10 checks passed
@davidsbatista davidsbatista deleted the fix/update-delete_by_filter-qdrant-signature branch February 2, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qdrant: to return int on delete_by_filter(self) so that the DocumentStore Protocol can be extended

2 participants