feat: QdrantDocumentStore return number deleted docs on delete_by_filter#2807
Merged
Merged
Conversation
…nce after delete operation
julian-risch
approved these changes
Feb 2, 2026
Member
julian-risch
left a comment
There was a problem hiding this comment.
Looks good to me!
Alternative approach would have been to use count_documents before and after the delete call but I don't think that's better.
Interestingly, there is an open issue in the qdrant repo about returning the number of deleted documents in the delete response: qdrant/qdrant#5761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Qdrant: to returnintondelete_by_filter(self)so that theDocumentStoreProtocolcan be extended #2800Proposed Changes:
How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.