-
Notifications
You must be signed in to change notification settings - Fork 253
feat: add DSPySignatureChatGenerator #2831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
49606b2
Draft DSPy generators implementation
Ryzhtus 9ddd737
Addded tests
Ryzhtus 27fe361
Remove generator, tests, and updates as discussed
Ryzhtus a03bce3
Applied formatting
Ryzhtus a8c6ce1
Add pydoc
Ryzhtus 5a91cbd
Merge branch 'main' into integration/dspy
Ryzhtus 0d951e0
Updates after review: imports, tests, project file
Ryzhtus 218419d
Merge branch 'main' into integration/dspy
Ryzhtus 3d0c273
PR Review fixes
Ryzhtus 98b74c4
ReAct and Serialization/Deserializaion examples
Ryzhtus 6318823
Renamed DSPyChatGenerator into DSPySignatureChatGenerator
Ryzhtus 1fcbc7f
Add author
Ryzhtus 2233a83
Fmt lint
Ryzhtus e50246f
Merge branch 'main' into integration/dspy
Ryzhtus ab591b6
Remove streaming_callback logic for now
Ryzhtus 207ac4f
Remove init files
Ryzhtus ef27e6a
Added an empty py.typed file
Ryzhtus a8bac2c
Add Github workflow
Ryzhtus 8aecd85
Fix linter warnings and errors
Ryzhtus 0e28d0e
Merge branch 'main' into integration/dspy
Ryzhtus 8956e9c
Merge branch 'main' into integration/dspy
Ryzhtus 17b3a5a
Remove double backticks
Ryzhtus 3113afd
Update github workflow
Ryzhtus a1029cd
Explicit type serialization
Ryzhtus 100497a
Fix silent fallbacks and added tests for such cases
Ryzhtus 3e6cb77
Merge branch 'main' into integration/dspy
Ryzhtus 87bb606
Update .github/workflows/dspy.yml
anakin87 237356e
Update .github/workflows/dspy.yml
anakin87 42c6c72
Merge branch 'main' into integration/dspy
Ryzhtus 7481d6d
Removed signature serialization example
Ryzhtus ba3c490
Added ruff rules related to docstrings
Ryzhtus 8075a22
Fix dspy version and avoid malicious litellm versions
Ryzhtus 640e535
Merge branch 'main' into integration/dspy
Ryzhtus d5d9eba
Added "D102", "D103" to the test file ignores
Ryzhtus 1b0e28d
Merge branch 'main' into dspy
anakin87 4004d6c
test coverage support
anakin87 5903a93
Merge branch 'integration/dspy' of https://github.com/Ryzhtus/haystac…
anakin87 1e52b70
llm set on the module level, not global
anakin87 c5930ae
Merge branch 'main' into integration/dspy
anakin87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| # This workflow comes from https://github.com/ofek/hatch-mypyc | ||
| # https://github.com/ofek/hatch-mypyc/blob/5a198c0ba8660494d02716cfc9d79ce4adfb1442/.github/workflows/test.yml | ||
| name: Test / dspy | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: "0 0 * * *" | ||
| pull_request: | ||
| paths: | ||
| - "integrations/dspy/**" | ||
| - "!integrations/dspy/*.md" | ||
| - ".github/workflows/dspy.yml" | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "integrations/dspy/**" | ||
| - "!integrations/dspy/*.md" | ||
| - ".github/workflows/dspy.yml" | ||
|
|
||
| defaults: | ||
| run: | ||
| working-directory: integrations/dspy | ||
|
|
||
| concurrency: | ||
| group: dspy-${{ github.head_ref || github.sha }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| PYTHONUNBUFFERED: "1" | ||
| FORCE_COLOR: "1" | ||
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
| TEST_MATRIX_OS: '["ubuntu-latest", "windows-latest", "macos-latest"]' | ||
| TEST_MATRIX_PYTHON: '["3.10", "3.14"]' | ||
|
|
||
| jobs: | ||
| compute-test-matrix: | ||
| runs-on: ubuntu-slim | ||
| defaults: | ||
| run: | ||
| working-directory: . | ||
| outputs: | ||
| os: ${{ steps.set.outputs.os }} | ||
| python-version: ${{ steps.set.outputs.python-version }} | ||
| steps: | ||
| - id: set | ||
| run: | | ||
| echo 'os=${{ github.event_name == 'push' && '["ubuntu-latest"]' || env.TEST_MATRIX_OS }}' >> "$GITHUB_OUTPUT" | ||
| echo 'python-version=${{ github.event_name == 'push' && '["3.10"]' || env.TEST_MATRIX_PYTHON }}' >> "$GITHUB_OUTPUT" | ||
|
|
||
| run: | ||
| name: Python ${{ matrix.python-version }} on ${{ startsWith(matrix.os, 'macos-') && 'macOS' || startsWith(matrix.os, 'windows-') && 'Windows' || 'Linux' }} | ||
| needs: compute-test-matrix | ||
| runs-on: ${{ matrix.os }} | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: ${{ fromJSON(needs.compute-test-matrix.outputs.os) }} | ||
| python-version: ${{ fromJSON(needs.compute-test-matrix.outputs.python-version) }} | ||
|
|
||
| steps: | ||
| - name: Support longpaths | ||
| if: matrix.os == 'windows-latest' | ||
| working-directory: . | ||
| run: git config --system core.longpaths true | ||
|
|
||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
|
|
||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Install Hatch | ||
| run: pip install hatch | ||
|
|
||
| - name: Lint | ||
| if: github.event_name != 'push' && matrix.python-version == '3.10' && runner.os == 'Linux' | ||
| run: hatch run fmt-check && hatch run test:types | ||
|
|
||
| - name: Run unit tests | ||
| run: hatch run test:unit-cov-retry | ||
|
|
||
| # On PR: generates coverage comment artifact. On push to main: stores coverage baseline on data branch. | ||
| - name: Store unit tests coverage | ||
| if: matrix.python-version == '3.10' && runner.os == 'Linux' && github.event_name != 'schedule' | ||
| uses: py-cov-action/python-coverage-comment-action@7188638f871f721a365d644f505d1ff3df20d683 # v3.40 | ||
| with: | ||
| GITHUB_TOKEN: ${{ github.token }} | ||
| COVERAGE_PATH: integrations/dspy | ||
| SUBPROJECT_ID: dspy | ||
| COMMENT_ARTIFACT_NAME: coverage-comment-dspy | ||
|
|
||
| - name: Run integration tests | ||
| run: hatch run test:integration-cov-append-retry | ||
|
|
||
| - name: Store combined coverage | ||
| if: github.event_name == 'push' | ||
| uses: py-cov-action/python-coverage-comment-action@7188638f871f721a365d644f505d1ff3df20d683 # v3.40 | ||
| with: | ||
| GITHUB_TOKEN: ${{ github.token }} | ||
| COVERAGE_PATH: integrations/dspy | ||
| SUBPROJECT_ID: dspy-combined | ||
| COMMENT_ARTIFACT_NAME: coverage-comment-dspy-combined | ||
|
|
||
| - name: Run unit tests with lowest direct dependencies | ||
| if: github.event_name != 'push' | ||
| run: | | ||
| hatch run uv pip compile pyproject.toml --resolution lowest-direct --output-file requirements_lowest_direct.txt | ||
| hatch -e test env run -- uv pip install -r requirements_lowest_direct.txt | ||
| hatch run test:unit | ||
|
|
||
| - name: Nightly - run unit tests with Haystack main branch | ||
| if: github.event_name == 'schedule' | ||
| run: | | ||
| hatch env prune | ||
| hatch -e test env run -- uv pip install git+https://github.com/deepset-ai/haystack.git@main | ||
| hatch run test:unit | ||
|
|
||
| notify-slack-on-failure: | ||
| needs: run | ||
| if: failure() && github.event_name == 'schedule' | ||
| runs-on: ubuntu-slim | ||
| steps: | ||
| - uses: deepset-ai/notify-slack-action@3cda73b77a148f16f703274198e7771340cf862b # v1 | ||
| with: | ||
| slack-webhook-url: ${{ secrets.SLACK_WEBHOOK_URL_NOTIFICATIONS }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.