feat(meta-llama): add timeout and max_retries to chat generator#2872
Merged
anakin87 merged 1 commit intodeepset-ai:mainfrom Feb 26, 2026
Merged
Conversation
anakin87
approved these changes
Feb 26, 2026
Member
anakin87
left a comment
There was a problem hiding this comment.
Thank you!
I also tested it locally and it works correctly.
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
timeoutandmax_retriestoMetaLlamaChatGenerator.__init__.OpenAIChatGeneratorviasuper().__init__(..., timeout=..., max_retries=...).to_dictserialization.timeout/max_retriesareNoneHow did you test it?
test_init_defaulttest_to_dict_defaulttest_from_dict_fail_wo_env_varhatch run test:unit tests/test_llama_chat_generator.pyAll selected tests passed on this branch.
Notes for the reviewer
Nonein this integration path, and tests were adjusted accordingly.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.