ci: adding FAISS github workflow#2879
Merged
davidsbatista merged 21 commits intomainfrom Feb 27, 2026
Merged
Conversation
github-actions
Bot
added
the
type:documentation
davidsbatista
requested review from
julian-risch
and removed request for
a team
julian-risch
requested changes
Feb 27, 2026
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
Let's add :raises: to docstrings. Otherwise looks good to me!
|
|
||
| :param documents: The list of documents to write. | ||
| :param policy: The policy to handle duplicate documents. | ||
| :return: The number of documents written. |
Member
There was a problem hiding this comment.
:raises:
ValueError: If ...
DuplicateDocumentError: If ...
DocumentStoreError: If ...| :param query_embedding: The query embedding. | ||
| :param top_k: The number of results to return. | ||
| :param filters: Filters to apply. | ||
| :return: A list of matching Documents. |
Member
There was a problem hiding this comment.
:raises:
FilterError: If ...
julian-risch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.