-
Notifications
You must be signed in to change notification settings - Fork 255
feat: Bedrock - support for FileContent + citations #2883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6da9e4e
feat: Bedrock - support for FileContent + citations
anakin87 7bb358b
tmp
anakin87 96b2933
unit tests
anakin87 ffd2239
more tests
anakin87 9a4b0ca
rm debug prints
anakin87 e9c0ca4
better mime type handling + text joining
anakin87 4e92392
image paths
anakin87 7707641
improve
anakin87 10bf78c
better
anakin87 ced7d17
Merge branch 'main' into filecontent-bedrock
anakin87 da26239
handle empty sanitized name
anakin87 ee79dc2
don't strip citations
anakin87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In l.485 we strip all white space from text content (
text := entry.get("text", "").strip()), joining them together like this might lead to missing white space I guess.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally changed this part of the code because while experimenting with citations, I realized that
" ".join()was introducing duplicate spaces (since the API already includes spacing).Based on your comment, I propose to use
"".join()and preserve the original text/citation as-is.See ee79dc2