fix: Remove NUL bytes when converting from haystack to pg documents#2892
Merged
anakin87 merged 6 commits intodeepset-ai:mainfrom Mar 2, 2026
Merged
fix: Remove NUL bytes when converting from haystack to pg documents#2892anakin87 merged 6 commits intodeepset-ai:mainfrom
anakin87 merged 6 commits intodeepset-ai:mainfrom
Conversation
anakin87
requested changes
Mar 2, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Just one small suggestion to access db_document["content"] fewer times
…s/pgvector/converters.py Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
anakin87
approved these changes
Mar 2, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Thank you!
I fixed format and pushed a small unrelated change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Existence of NUL bytes (
"\x00") in HaystackDocument.contentfields caused error when trying to write these document(s) into PostgreSQL as PostgreSQL text fields cannot contain NUL (0x00) bytes. To fix this, I updated the_from_haystack_to_pg_documentsconverter called inPgvectorDocumentStore.write_documentsandPgvectorDocumentStore.write_documents_asyncto remove all NUL bytes inpg_documents["content"].How did you test it?
Updated unit test covering conversion of Haystack documents into pg documents.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.