feat: use reasoning field in StreamingChunk for Bedrock#2901
Merged
julian-risch merged 1 commit intodeepset-ai:mainfrom Mar 7, 2026
Merged
Conversation
Populate StreamingChunk.reasoning with ReasoningContent instead of storing reasoning content deltas in meta["reasoning_contents"]. Update _process_reasoning_contents to read from chunk.reasoning.extra instead of chunk.meta.
|
|
julian-risch
approved these changes
Mar 7, 2026
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for your contribution @Br1an67 . I am sorry that it took a bit longer than usual to review your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
reasoningfield inStreamingChunkhaystack#10480Proposed Changes:
Populate
StreamingChunk.reasoningwithReasoningContentinstead of storing reasoning content deltas inmeta["reasoning_contents"]. This aligns the Bedrock integration with the standardStreamingChunk.reasoningfield, consistent with other integrations (Ollama in #2850, Google GenAI in #2900).Changes:
_process_streaming_event(): CreateReasoningContentwith reasoning text and Bedrock-specific block data inextra, pass viareasoningkwarg instead ofmeta["reasoning_contents"]_process_reasoning_contents(): Read fromchunk.reasoning.extra["reasoning_contents"]instead ofchunk.meta["reasoning_contents"]How did you test it?
test_process_streaming_response_one_tool_call_with_thinkingverifying streaming chunks carry reasoning inchunk.reasoningand not inchunk.metaNotes for the reviewer
The
extrafield onReasoningContentpreserves the Bedrock-specific structure (block indices, signatures, redacted content) needed for round-tripping with the Bedrock API.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.