feat: adding new operations to ValkeyDocumentStore#2910
Merged
davidsbatista merged 19 commits intomainfrom Mar 6, 2026
Merged
Conversation
github-actions
Bot
added
integration:valkey
type:documentation
anakin87
requested changes
Mar 5, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Good work overall.
I left some comments and questions.
| assert doc.meta["score"] >= 0.7 | ||
|
|
||
| # --- delete_by_filter, update_by_filter, count_documents_by_filter --- | ||
|
|
Member
There was a problem hiding this comment.
Here in tests, could we use the tests you added in haystack/testing/document_store.py?
Contributor
Author
|
There was a split to the astra integration tests file, I wrongly mixed my local branches, reverted it. |
anakin87
approved these changes
Mar 6, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
I left one minor comment on test names but looks good.
Feel free to merge once fixed.
Co-authored-by: Stefano Fiorucci <stefanofiorucci@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Adding the following new operations, both sync and async:
How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.