Skip to content

ci: send Slack notifications on CI failures#2911

Merged
anakin87 merged 8 commits intomainfrom
slack-notifications
Mar 6, 2026
Merged

ci: send Slack notifications on CI failures#2911
anakin87 merged 8 commits intomainfrom
slack-notifications

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Mar 5, 2026

Related Issues

Proposed Changes:

Instead of sending DD events for CI failures and then Slack notifications from DD monitors, skip DD

  • uses the composite action https://github.com/deepset-ai/notify-slack-action
  • adopt the composite action in all integrations workflows
    • to make sure we get a single notification when a matrix workflow fails (not one for each element in the matrix), I created a new lightweight job (uses ubuntu-slim)
  • updated the template for new integrations to use this new pattern
  • removed the old send_failure composite action (integrating with DD)

To make this work, before opening this PR, I completed the setup described in the Slack documentation.

How did you test it?

In this PR, I temporarily made Anthropic workflow fail and got the expected notification.

image

Since this was a test, I avoided tagging people. The actual action would tag @here in the Slack channel.

Checklist

@anakin87 anakin87 changed the title try notify Slack on failure ci: send Slack notifications on CI failures Mar 5, 2026
@anakin87 anakin87 self-assigned this Mar 5, 2026
@anakin87 anakin87 marked this pull request as ready for review March 5, 2026 11:05
@anakin87 anakin87 requested a review from a team as a code owner March 5, 2026 11:05
@anakin87 anakin87 requested review from bogdankostic and removed request for a team March 5, 2026 11:05
@anakin87
Copy link
Copy Markdown
Member Author

anakin87 commented Mar 6, 2026

Nvidia tests failing due to #2838 (unrelated to this PR)

Copy link
Copy Markdown
Contributor

@bogdankostic bogdankostic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in principle, just wondering why we use a different pattern in CI_license_compliance.yml.

Comment on lines +92 to +96
- name: Notify Slack on nightly failure
if: failure() && github.event_name == 'schedule'
uses: ./.github/actions/send_failure
uses: deepset-ai/notify-slack-action@v1
with:
title: |
Core integrations license compliance nightly failure: ${{ github.workflow }}
api-key: ${{ secrets.CORE_DATADOG_API_KEY }}

No newline at end of file
slack-webhook-url: ${{ secrets.SLACK_WEBHOOK_URL_NOTIFICATIONS }} No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all other workflow files we have the notification step as a separate job.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in other workflows, we are using a separate job for this reason

to make sure we get a single notification when a matrix workflow fails (not one for each element in the matrix), I created a new lightweight job (uses ubuntu-slim)

In this case, we don't need a matrix: the license check only needs to run on a single operating system and with one Python version. Where possible, it's better to have a step instead of a job because GitHub does not need to spin up a new container.

Comment thread .github/workflows/anthropic.yml Outdated
@anakin87 anakin87 merged commit bce1812 into main Mar 6, 2026
278 of 281 checks passed
@anakin87 anakin87 deleted the slack-notifications branch March 6, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment