fix: converting to staticmethod some tests in AstraDocumentStore#2928
Merged
davidsbatista merged 13 commits intomainfrom Mar 13, 2026
Merged
fix: converting to staticmethod some tests in AstraDocumentStore#2928davidsbatista merged 13 commits intomainfrom
staticmethod some tests in AstraDocumentStore#2928davidsbatista merged 13 commits intomainfrom
Conversation
… in-place doc modifications
Contributor
Author
|
when you have time @julian-risch have look on this one |
julian-risch
approved these changes
Mar 13, 2026
Member
julian-risch
left a comment
julian-risch
left a comment
There was a problem hiding this comment.
Looks good to me!
My only comment is that ChromaDocumentStore is the only DocumentStore so far where we have this as staticmethod and we should aim for consistency in the codebase: https://github.com/search?q=repo%3Adeepset-ai%2Fhaystack-core-integrations%20assert_documents_are_equal&type=code
Contributor
Author
|
This is a pattern I see often. I think it has to do with IDE code completion that automatically assumes it's an instance method and always adds the Not a top priority, but I always tend to correct those when I see them. I can adjust/correct the others as I make each doc store use the Mixin tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.