feat: Add missing async methods for WeaviateDocumentStore#2929
Merged
anakin87 merged 7 commits intodeepset-ai:mainfrom Mar 11, 2026
Merged
feat: Add missing async methods for WeaviateDocumentStore#2929anakin87 merged 7 commits intodeepset-ai:mainfrom
WeaviateDocumentStore#2929anakin87 merged 7 commits intodeepset-ai:mainfrom
Conversation
github-actions
Bot
added
integration:weaviate
type:documentation
anakin87
requested changes
Mar 10, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Thank you for this contribution!
I left some initial comments.
… and update docstrings for write_documents and write_documents_async
anakin87
requested changes
Mar 11, 2026
Contributor
Author
|
@anakin87 Thanks for the review! All of your comments should have now been addressed. |
anakin87
reviewed
Mar 11, 2026
anakin87
approved these changes
Mar 11, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
Thank you for the good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Added async methods:
count_documents_async,filter_documents_async,write_documents_async,delete_documents_asyncanddelete_all_documents_async. I bumped the version of Weaviate in the docker-compose file as it is needed for server-side batching used in asynchronous batch writing in_batch_write_async.How did you test it?
Added new integration tests.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.