Skip to content

chore!: CohereChatGenerator - remove **kwargs init parameter + fix test#2948

Merged
anakin87 merged 6 commits intomainfrom
fix-cohere-test
Mar 11, 2026
Merged

chore!: CohereChatGenerator - remove **kwargs init parameter + fix test#2948
anakin87 merged 6 commits intomainfrom
fix-cohere-test

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Mar 11, 2026

Related Issues

Proposed Changes:

  • fix failing test by removing unnecessary stream parameter
  • remove the confusing **kwargs parameter (breaking change)
  • make sure that Generator (which inherits from Chat Generator) still works correctly
  • other minor improvements
    • rely on default secrets serde
    • use a more reliable (and cheap) model for test_pipeline_with_cohere_chat_generator that was frequently re-run

How did you test it?

CI

Notes for the reviewer

I'd release a new major version because of the breaking change

Checklist

@github-actions github-actions Bot added the type:documentation Improvements or additions to documentation label Mar 11, 2026
@anakin87 anakin87 changed the title fix Cohere test chore!: CohereChatGenerator - remove **kwargs init parameter Mar 11, 2026
@anakin87 anakin87 changed the title chore!: CohereChatGenerator - remove **kwargs init parameter chore!: CohereChatGenerator - remove **kwargs init parameter + fix test Mar 11, 2026
@anakin87 anakin87 self-assigned this Mar 11, 2026
@anakin87 anakin87 marked this pull request as ready for review March 11, 2026 10:59
@anakin87 anakin87 requested a review from a team as a code owner March 11, 2026 10:59
@anakin87 anakin87 requested review from davidsbatista and removed request for a team March 11, 2026 10:59
Copy link
Copy Markdown
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nit: maybe is worth it to also use cheaper models for other live tests? test_live_run_with_mixed_tools

@anakin87
Copy link
Copy Markdown
Member Author

anakin87 commented Mar 11, 2026

nit: maybe is worth it to also use cheaper models for other live tests? test_live_run_with_mixed_tools

Done in 57074b8

This also seems to have reduced test time significantly: on Linux/Python 3.13, from 2m30s to 54s

@anakin87 anakin87 merged commit 2028be4 into main Mar 11, 2026
13 checks passed
@anakin87 anakin87 deleted the fix-cohere-test branch March 11, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:cohere type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants