chore!: CohereChatGenerator - remove **kwargs init parameter + fix test#2948
Merged
chore!: CohereChatGenerator - remove **kwargs init parameter + fix test#2948
**kwargs init parameter + fix test#2948Conversation
**kwargs init parameter
**kwargs init parameter**kwargs init parameter + fix test
davidsbatista
approved these changes
Mar 11, 2026
Contributor
davidsbatista
left a comment
There was a problem hiding this comment.
LGTM!
nit: maybe is worth it to also use cheaper models for other live tests? test_live_run_with_mixed_tools
Member
Author
Done in 57074b8 This also seems to have reduced test time significantly: on Linux/Python 3.13, from 2m30s to 54s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
streamparameter that they recently droppedCohereChatGeneratorexposes**kwargsin__init__, which are then forwarded to Cohere client; this is a duplicate ofgeneration_kwargs.Proposed Changes:
streamparameter**kwargsparameter (breaking change)test_pipeline_with_cohere_chat_generatorthat was frequently re-runHow did you test it?
CI
Notes for the reviewer
I'd release a new major version because of the breaking change
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.