fix: fix wrong batching in Google GenAI Document Embedder#2951
Merged
fix: fix wrong batching in Google GenAI Document Embedder#2951
Conversation
sjrl
approved these changes
Mar 11, 2026
Contributor
sjrl
left a comment
sjrl
left a comment
There was a problem hiding this comment.
Thanks for the fix! Apologies for missing this on the original review of this contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
We noticed that the Google GenAI Document Embedder behaved differently than when using the Google API directly, leading to non-meaningful results for text retrieval.
After investigation, it turned out that the batching mechanism was wrong, actually passing 1-character texts to the embedding API
Proposed Changes:
How did you test it?
CI, new tests
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.