feat: Add missing operations to ArcadeDBDocumentstore#2952
Merged
davidsbatista merged 6 commits intodeepset-ai:mainfrom Mar 16, 2026
Merged
feat: Add missing operations to ArcadeDBDocumentstore#2952davidsbatista merged 6 commits intodeepset-ai:mainfrom
ArcadeDBDocumentstore#2952davidsbatista merged 6 commits intodeepset-ai:mainfrom
Conversation
Member
|
@julian-risch this PR looks quite good but I'd prefer you to have a look: I realized that most tests are skipped in PRs from forks, even if they could run (just use a Docker container). Even if it's not the PR's main point, it would be great to fix this behavior soon. |
Contributor
|
@julian-risch I can also take over this one, if that's OK with you. If so, just assign me and unassign yourself (if you want). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
ArcadeDBDocumentstore#2906Proposed Changes:
Add the following operations:
to
ArcadeDBDocumentstore.How did you test it?
Tested using the Mixin tests that were mentioned in the issue.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.