Skip to content

feat: Add missing operations to ArcadeDBDocumentstore#2952

Merged
davidsbatista merged 6 commits intodeepset-ai:mainfrom
maxdswain:add-operations-arcadedb
Mar 16, 2026
Merged

feat: Add missing operations to ArcadeDBDocumentstore#2952
davidsbatista merged 6 commits intodeepset-ai:mainfrom
maxdswain:add-operations-arcadedb

Conversation

@maxdswain
Copy link
Copy Markdown
Contributor

@maxdswain maxdswain commented Mar 11, 2026

Related Issues

Proposed Changes:

Add the following operations:

  • delete_all_documents()
  • delete_by_filter()
  • update_by_filter()

to ArcadeDBDocumentstore.

How did you test it?

Tested using the Mixin tests that were mentioned in the issue.

Notes for the reviewer

Checklist

@maxdswain maxdswain requested a review from a team as a code owner March 11, 2026 19:36
@maxdswain maxdswain requested review from anakin87 and removed request for a team March 11, 2026 19:36
@github-actions github-actions Bot added integration:arcadedb type:documentation Improvements or additions to documentation labels Mar 11, 2026
@anakin87 anakin87 requested a review from julian-risch March 12, 2026 06:39
@anakin87
Copy link
Copy Markdown
Member

@julian-risch this PR looks quite good but I'd prefer you to have a look: I realized that most tests are skipped in PRs from forks, even if they could run (just use a Docker container). Even if it's not the PR's main point, it would be great to fix this behavior soon.

@davidsbatista
Copy link
Copy Markdown
Contributor

davidsbatista commented Mar 13, 2026

@julian-risch I can also take over this one, if that's OK with you. If so, just assign me and unassign yourself (if you want).

@julian-risch julian-risch requested review from davidsbatista and removed request for davidsbatista and julian-risch March 13, 2026 15:28
@davidsbatista davidsbatista self-assigned this Mar 16, 2026
Copy link
Copy Markdown
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidsbatista davidsbatista merged commit 3b88bd3 into deepset-ai:main Mar 16, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:arcadedb type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing operations to ArcadeDBDocumentstore

3 participants