fix: Weaviate - stop ignoring _split_overlap meta field#2966
Merged
julian-risch merged 2 commits intomainfrom Mar 17, 2026
Merged
fix: Weaviate - stop ignoring _split_overlap meta field#2966julian-risch merged 2 commits intomainfrom
julian-risch merged 2 commits intomainfrom
Conversation
julian-risch
requested review from
davidsbatista
and removed request for
a team
github-actions
Bot
added
integration:weaviate
type:documentation
anakin87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
_split_overlapfield generated by theDocumentSplitter#1172Proposed Changes:
_split_overlapmeta field and added a test to check writing it to weaviate. Basically these changes revert fix: Weaviate - skip_split_overlapmeta field #1173 and replacetest_meta_split_overlap_is_skippedwithtest_split_overlap_preservedHow did you test it?
Ran all document store tests locally, except for test_connect_to_weaviate_cloud
Notes for the reviewer
The issue was in the backlog without assigned priority for quite some time and the underlying issue in Weaviate was fixed in the meantime.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.