fix: fix the conversion of cohere chunks to Haystack streaming chunks#2968
Merged
fix: fix the conversion of cohere chunks to Haystack streaming chunks#2968
Conversation
Member
|
@sjrl sorry, I merged and released this as an experiment to generate a new API reference, but I did not realize it does not touch docstrings. Hope it was already OK. |
Contributor
Author
yeah no worries it was good to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
TOOL_CALLS-->TOOL_CALLStreamingChunk.start = Truewas incorrect for the first non-emptytool-plan-deltachunkStreamingChunk.startwas incorrectly set toTrueontool-call-endHow did you test it?
Also tested locally with the script
Which now produces the expected formatted streaming response
Previously looked like
Notes for the reviewer
Once this is merged I'll follow it up with a PR to resolve #2179
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.