Skip to content

chore: enable ANN ruff ruleset for azure_doc_intelligence integration#2981

Merged
julian-risch merged 1 commit intomainfrom
feat/azure-doc-intelligence-type-annotations
Mar 18, 2026
Merged

chore: enable ANN ruff ruleset for azure_doc_intelligence integration#2981
julian-risch merged 1 commit intomainfrom
feat/azure-doc-intelligence-type-annotations

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Mar 18, 2026

Related Issues

None

Proposed Changes:

  • Add ANN (flake8-annotations) to ruff select in pyproject.toml
  • Add ANN401 to ruff ignore (allow Any for SDK boundaries)
  • Exclude tests/**/* from ANN checks via per-file-ignores
  • Add -> None return type annotations to __init__ and warm_up

How did you test it?

Ran tests locally

Notes for the reviewer

Checklist

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
"YTT",
]
ignore = [
"ANN401", # Allow Any - used legitimately for dynamic types and SDK boundaries
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any is only used in dict[str, Any]. Either way I believe it's a good convention to exclude ANN401 in most of our integrations.

@julian-risch julian-risch marked this pull request as ready for review March 18, 2026 13:15
@julian-risch julian-risch requested a review from a team as a code owner March 18, 2026 13:15
@julian-risch julian-risch requested review from bogdankostic and removed request for a team March 18, 2026 13:15
@julian-risch julian-risch enabled auto-merge (squash) March 18, 2026 13:16
@julian-risch julian-risch merged commit bda5636 into main Mar 18, 2026
11 checks passed
@julian-risch julian-risch deleted the feat/azure-doc-intelligence-type-annotations branch March 18, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants