Skip to content

chore: enable ANN ruff ruleset for azure_doc_intelligence integration #2981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-risch merged 1 commit into from
Mar 18, 2026
Merged

chore: enable ANN ruff ruleset for azure_doc_intelligence integration #2981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion integrations/azure_doc_intelligence/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ line-length = 120
[tool.ruff.lint]
select = [
"A",
"ANN",
"ARG",
"B",
"C",
Expand All @@ -115,6 +116,7 @@ select = [
"YTT",
]
ignore = [
"ANN401", # Allow Any - used legitimately for dynamic types and SDK boundaries
Copy link
Copy Markdown
Member Author

@julian-risch julian-risch Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any is only used in dict[str, Any]. Either way I believe it's a good convention to exclude ANN401 in most of our integrations.

# Allow non-abstract empty methods in abstract base classes
"B027",
# Allow function calls in argument defaults (common Haystack pattern for Secret.from_env_var)
Expand Down Expand Up @@ -145,7 +147,7 @@ ban-relative-imports = "parents"

[tool.ruff.lint.per-file-ignores]
# Tests can use magic values, assertions, and relative imports
"tests/**/*" = ["PLR2004", "S101", "TID252"]
"tests/**/*" = ["PLR2004", "S101", "TID252", "ANN"]

[tool.coverage.run]
source = ["haystack_integrations"]
Expand Down
4 changes: 2 additions & 2 deletions ...gence/src/haystack_integrations/components/converters/azure_doc_intelligence/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def __init__(
api_key: Secret = Secret.from_env_var("AZURE_DI_API_KEY"),
model_id: str = "prebuilt-document",
store_full_path: bool = False,
):
) -> None:
"""
Creates an AzureDocumentIntelligenceConverter component.

Expand All @@ -93,7 +93,7 @@ def __init__(
self.store_full_path = store_full_path
self.client: DocumentIntelligenceClient | None = None

def warm_up(self):
def warm_up(self) -> None:
"""
Initializes the Azure Document Intelligence client.
"""
Expand Down
Loading