Skip to content

chore: enable ANN ruff ruleset for cohere integration#2983

Merged
julian-risch merged 1 commit intomainfrom
feat/cohere-type-annotations
Mar 18, 2026
Merged

chore: enable ANN ruff ruleset for cohere integration#2983
julian-risch merged 1 commit intomainfrom
feat/cohere-type-annotations

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Mar 18, 2026

Related Issues

None

Proposed Changes:

  • Add ANN (flake8-annotations) to ruff select in pyproject.toml
  • Add ANN401 to ruff ignore (allow Any for SDK boundaries)
  • Exclude tests/**/* from ANN checks via per-file-ignores
  • Add -> None return type annotations to __init__ in text_embedder.py, document_embedder.py, generator.py, chat_generator.py, and ranker.py
  • Add -> str return type annotation to EmbeddingTypes.__str__

How did you test it?

Ran tests locally

Notes for the reviewer

Checklist

@github-actions github-actions Bot added integration:cohere integration:deepeval type:documentation Improvements or additions to documentation labels Mar 18, 2026
@julian-risch julian-risch force-pushed the feat/cohere-type-annotations branch 2 times, most recently from b866f08 to 771b36a Compare March 18, 2026 13:25
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@julian-risch julian-risch force-pushed the feat/cohere-type-annotations branch from 771b36a to 47aa76f Compare March 18, 2026 13:30
@julian-risch julian-risch marked this pull request as ready for review March 18, 2026 13:31
@julian-risch julian-risch requested a review from a team as a code owner March 18, 2026 13:31
@julian-risch julian-risch requested review from anakin87 and removed request for a team March 18, 2026 13:31
@julian-risch julian-risch enabled auto-merge (squash) March 18, 2026 13:31
@julian-risch julian-risch merged commit f812e94 into main Mar 18, 2026
13 checks passed
@julian-risch julian-risch deleted the feat/cohere-type-annotations branch March 18, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants