Skip to content

chore: enable ANN ruff ruleset and add missing docstrings for deepeval integration#2985

Merged
julian-risch merged 1 commit intomainfrom
feat/deepeval-type-annotations
Mar 18, 2026
Merged

chore: enable ANN ruff ruleset and add missing docstrings for deepeval integration#2985
julian-risch merged 1 commit intomainfrom
feat/deepeval-type-annotations

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Mar 18, 2026

Related Issues

None

Proposed Changes:

  • Add ANN (flake8-annotations) to ruff select in pyproject.toml
  • Add ANN401 to ruff ignore (allow Any for SDK boundaries)
  • Exclude tests/**/* from ANN checks via per-file-ignores
  • Add -> None return type to DeepEvalEvaluator.__init__ and _init_backend
  • Add -> str to DeepEvalMetric.__str__
  • Add -> dict[str, Any] to MetricResult.to_dict
  • Add **kwargs: Any and -> None to InputConverters._validate_input_elements
  • Add docstrings to MetricResult.to_dict, MetricDescriptor.new, InputConverters.validate_input_parameters, and the InputConverters/OutputConverters converter methods

How did you test it?

Ran tests locally

Notes for the reviewer

Checklist

…l integration

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added integration:deepeval type:documentation Improvements or additions to documentation labels Mar 18, 2026
@julian-risch julian-risch marked this pull request as ready for review March 18, 2026 13:26
@julian-risch julian-risch requested a review from a team as a code owner March 18, 2026 13:26
@julian-risch julian-risch requested review from davidsbatista and removed request for a team March 18, 2026 13:26
@julian-risch julian-risch enabled auto-merge (squash) March 18, 2026 13:26
@julian-risch julian-risch merged commit 4a5b3ee into main Mar 18, 2026
13 checks passed
@julian-risch julian-risch deleted the feat/deepeval-type-annotations branch March 18, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:deepeval type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants