chore: enable ANN ruff ruleset for elasticsearch integration#2986
Merged
julian-risch merged 1 commit intomainfrom Mar 18, 2026
Merged
chore: enable ANN ruff ruleset for elasticsearch integration#2986julian-risch merged 1 commit intomainfrom
julian-risch merged 1 commit intomainfrom
Conversation
Add ANN (flake8-annotations) to ruff select, ignore ANN401 (Any is used legitimately for **kwargs and ES SDK boundaries), exclude tests from ANN checks, and add missing -> None return type annotations to __init__ and _ensure_initialized. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sjrl
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
None
Proposed Changes:
ANN(flake8-annotations) to ruffselectinpyproject.tomlANN401to ruffignore(allowAnyfor**kwargsand Elasticsearch SDK boundaries)tests/**/*from ANN checks viaper-file-ignores-> Nonereturn type annotations to__init__inElasticsearchBM25Retriever,ElasticsearchEmbeddingRetriever,ElasticsearchSQLRetriever, andElasticsearchDocumentStore-> Nonereturn type annotation to_ensure_initializedinElasticsearchDocumentStoreHow did you test it?
Ran tests locally
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.