Skip to content

chore: add ANN type annotations to stackit, togetherai, unstructured, valkey, watsonx, weave, weaviate#2994

Merged
julian-risch merged 2 commits into
mainfrom
feat/stackit-togetherai-unstructured-valkey-watsonx-weave-weaviate-ann
Mar 20, 2026
Merged

chore: add ANN type annotations to stackit, togetherai, unstructured, valkey, watsonx, weave, weaviate#2994
julian-risch merged 2 commits into
mainfrom
feat/stackit-togetherai-unstructured-valkey-watsonx-weave-weaviate-ann

Conversation

@julian-risch
Copy link
Copy Markdown
Member

@julian-risch julian-risch commented Mar 19, 2026

Related Issues

None

Proposed Changes:

  • Added "ANN" ruleset (flake8-annotations) to ruff select for stackit, togetherai, unstructured, valkey, watsonx, weave, and weaviate integrations
  • Added "ANN401" to ruff ignore (allows Any at dynamic/SDK boundaries) for all 7 integrations
  • Added "ANN" to tests/**/* per-file-ignores for all 7 integrations (tests don't need type annotations)
  • Added "ANN" to examples/**/* (or example/**/*) per-file-ignores where example scripts existed (togetherai, valkey, watsonx, weave)
  • Fixed all ANN violations in source files: added -> None to __init__ methods across stackit, togetherai, unstructured, valkey, watsonx, and weaviate; added return types to __str__, resolve_value, _clean_connection_settings, client, and async_client in weaviate
  • Added docstrings for two __init__ methods in integrations/unstructured/src/haystack_integrations/components/converters/unstructured/converter.py
    and integrations/valkey/src/haystack_integrations/components/retrievers/valkey/embedding_retriever.py

How did you test it?

Ran tests locally

Notes for the reviewer

StackitChatGenerator test fails because of ClassVar of SUPPORTED_MODELS. Patch release is in progress in Haystack. I wouldn't block the PR because of that. This PR is the last one in the series of PRs that enforce ruff rules for integrations.

Checklist

… valkey, watsonx, weave, weaviate

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d valkey

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@julian-risch julian-risch marked this pull request as ready for review March 19, 2026 18:21
@julian-risch julian-risch requested a review from a team as a code owner March 19, 2026 18:21
@julian-risch julian-risch requested review from bogdankostic and removed request for a team March 19, 2026 18:21
@julian-risch julian-risch enabled auto-merge (squash) March 19, 2026 18:21
@julian-risch julian-risch merged commit 07b26a8 into main Mar 20, 2026
42 of 43 checks passed
@julian-risch julian-risch deleted the feat/stackit-togetherai-unstructured-valkey-watsonx-weave-weaviate-ann branch March 20, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants